Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip]: correct set tsconfig for mocha test under plugins/code/server/__test__ #34754

Closed
wants to merge 3 commits into from
Closed

[wip]: correct set tsconfig for mocha test under plugins/code/server/__test__ #34754

wants to merge 3 commits into from

Conversation

zfy0701
Copy link
Contributor

@zfy0701 zfy0701 commented Apr 8, 2019

No description provided.

@zfy0701 zfy0701 requested a review from spalger April 8, 2019 21:28
@zfy0701
Copy link
Contributor Author

zfy0701 commented Apr 8, 2019 •
edited
Loading

currently the tsconfig for __test__ project is a little bit weird:
https://github.com/elastic/kibana/pull/34754/files#diff-7706e0dee5c9f5d19ad3ed79f5c0a7ffR3
in order to get the check pass I need to do some strange config

However, I was wondering if we should just move all the test under x-pack/test folder

@zfy0701 zfy0701 added the :Code label Apr 8, 2019
@zfy0701 zfy0701 changed the title [Code]: correct set tsconfig for mocha test [Code]: correct set tsconfig for mocha test under plugins/code/server/__test__ Apr 8, 2019
@zfy0701 zfy0701 force-pushed the feature/merge-code branch from bb09101 to b04fa24 Compare April 8, 2019 22:36
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@zfy0701 zfy0701 mentioned this pull request Apr 15, 2019
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@zfy0701
Copy link
Contributor Author

zfy0701 commented Apr 20, 2019

close this for now in favor of jest integration test in the feature

@zfy0701 zfy0701 removed the request for review from spalger April 21, 2019 15:10
@zfy0701 zfy0701 changed the title [Code]: correct set tsconfig for mocha test under plugins/code/server/__test__ [wip]: correct set tsconfig for mocha test under plugins/code/server/__test__ Apr 21, 2019
spalger
spalger reviewed Apr 22, 2019
View reviewed changes
src/dev/typescript/projects.ts
@@ -38,6 +38,9 @@ export const PROJECTS = [
...glob
.sync('test/plugin_functional/plugins/*/tsconfig.json', { cwd: REPO_ROOT })
.map(path => new Project(resolve(REPO_ROOT, path))),
...glob
.sync('x-pack/plugins/**/__tests__/tsconfig.json', { cwd: REPO_ROOT })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This glob is too expansive, it covers way too many locations, please pick something a little more static (lets stick to a single * max)

@zfy0701 zfy0701 closed this Apr 23, 2019
@zfy0701 zfy0701 deleted the fix_test_types branch April 23, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zfy0701 @elasticmachine @spalger