Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] Add location, fix name badge links for Synthetics SLOs (#210695) #210930

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[9.0] Add location, fix name badge links for Synthetics SLOs (#210695) #210930

merged 2 commits into from
Feb 18, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

@baileycash-elastic
Add location, fix name badge links for Synthetics SLOs (elastic#210695)
b2ba7a0 
## Summary

- Implements elastic#178138
- Fixes a bug where clicking on the existing link to the monitor via the
name badge led failed to load any data.

## Release Notes
- Fixes a bug where clicking on the name badge for a synthetics monitor
on an SLO details page would lead to a page that failed to load monitor
details.
- Adds a working link to the location badge on synthetics SLOs that will
route the user to the monitors page with a filter applied that matches
the location of the origin SLO.

![Screenshot 2025-02-11 at 3 31
15 PM](https://github.com/user-attachments/assets/1df39069-fc42-4c33-a7e5-8395b2730f43)
![Screenshot 2025-02-11 at 3 31
34 PM](https://github.com/user-attachments/assets/f1b3180f-eb9c-4f3b-9ff6-66bd4d1f8d5b)

(cherry picked from commit 4d3cf33)
@kibanamachine kibanamachine enabled auto-merge (squash) February 12, 2025 20:13
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 12, 2025
@kibanamachine kibanamachine mentioned this pull request Feb 12, 2025
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit 852a008 into elastic:9.0 Feb 18, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #71 / ObservabilityApp Custom threshold preview chart does render the empty chart only once at bootstrap

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 967 968 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 690 691 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 791.9KB 792.2KB +300.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 89.8KB 89.9KB +95.0B
synthetics 36.5KB 36.7KB +200.0B
total +295.0B
Unknown metric groups

API count

id before after diff
observability 698 699 +1

History

cc @baileycash-elastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@baileycash-elastic baileycash-elastic

Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @baileycash-elastic @shahzad31