Add location, fix name badge links for Synthetics SLOs #210695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
approved these changes
Feb 12, 2025
...solutions/observability/plugins/synthetics/public/apps/locators/group_monitor_by_location.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
b4e19d4 to
0ba39c9
Compare
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13293935708 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
## Summary - Implements elastic#178138 - Fixes a bug where clicking on the existing link to the monitor via the name badge led failed to load any data. ## Release Notes - Fixes a bug where clicking on the name badge for a synthetics monitor on an SLO details page would lead to a page that failed to load monitor details. - Adds a working link to the location badge on synthetics SLOs that will route the user to the monitors page with a filter applied that matches the location of the origin SLO.   (cherry picked from commit 4d3cf33)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Feb 18, 2025
#210930) # Backport This will backport the following commits from `main` to `9.0`: - [Add location, fix name badge links for Synthetics SLOs (#210695)](#210695) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T20:08:13Z","message":"Add location, fix name badge links for Synthetics SLOs (#210695)\n\n## Summary\r\n\r\n- Implements #178138 \r\n- Fixes a bug where clicking on the existing link to the monitor via the\r\nname badge led failed to load any data.\r\n\r\n## Release Notes\r\n- Fixes a bug where clicking on the name badge for a synthetics monitor\r\non an SLO details page would lead to a page that failed to load monitor\r\ndetails.\r\n- Adds a working link to the location badge on synthetics SLOs that will\r\nroute the user to the monitors page with a filter applied that matches\r\nthe location of the origin SLO.\r\n\r\n\r\n","sha":"4d3cf33ffd6d561cb73c1bccd53c643f3846cc1e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","release_note:fix","v9.0.0","backport:prev-minor","Team:obs-ux-management","v9.1.0"],"title":"Add location, fix name badge links for Synthetics SLOs","number":210695,"url":"https://github.com/elastic/kibana/pull/210695","mergeCommit":{"message":"Add location, fix name badge links for Synthetics SLOs (#210695)\n\n## Summary\r\n\r\n- Implements #178138 \r\n- Fixes a bug where clicking on the existing link to the monitor via the\r\nname badge led failed to load any data.\r\n\r\n## Release Notes\r\n- Fixes a bug where clicking on the name badge for a synthetics monitor\r\non an SLO details page would lead to a page that failed to load monitor\r\ndetails.\r\n- Adds a working link to the location badge on synthetics SLOs that will\r\nroute the user to the monitors page with a filter applied that matches\r\nthe location of the origin SLO.\r\n\r\n\r\n","sha":"4d3cf33ffd6d561cb73c1bccd53c643f3846cc1e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210695","number":210695,"mergeCommit":{"message":"Add location, fix name badge links for Synthetics SLOs (#210695)\n\n## Summary\r\n\r\n- Implements #178138 \r\n- Fixes a bug where clicking on the existing link to the monitor via the\r\nname badge led failed to load any data.\r\n\r\n## Release Notes\r\n- Fixes a bug where clicking on the name badge for a synthetics monitor\r\non an SLO details page would lead to a page that failed to load monitor\r\ndetails.\r\n- Adds a working link to the location badge on synthetics SLOs that will\r\nroute the user to the monitors page with a filter applied that matches\r\nthe location of the origin SLO.\r\n\r\n\r\n","sha":"4d3cf33ffd6d561cb73c1bccd53c643f3846cc1e"}}]}] BACKPORT--> Co-authored-by: Bailey Cash <bailey.cash@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Notes