Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types #210399

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types #210399

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40ac022
Retrying runSoon
ymao1 Feb 10, 2025
db6b466
Cleanup
ymao1 Feb 10, 2025
9b280c3
Merge branch 'main' of github.com:elastic/kibana into flaky-test-208459
ymao1 Feb 10, 2025
a6dd169
Merge branch 'main' into flaky-test-208459
elasticmachine Feb 11, 2025
8c6887f
PR feedback
ymao1 Feb 12, 2025
ae7a0b1
Merge branch 'main' of github.com:elastic/kibana into flaky-test-208459
ymao1 Feb 12, 2025
934376a
Merge branch 'flaky-test-208459' of github.com:ymao1/kibana into flak…
ymao1 Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions x-pack/platform/plugins/shared/task_manager/server/integration_tests/removed_types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ jest.mock('../monitoring/workload_statistics', () => {
};
});

// FLAKY: https://github.com/elastic/kibana/issues/208459
describe.skip('unrecognized task types', () => {
describe('unrecognized task types', () => {
let esServer: TestElasticsearchUtils;
let kibanaServer: TestKibanaUtils;
let taskManagerPlugin: TaskManagerStartContract;
Expand Down Expand Up @@ -114,8 +113,16 @@ describe.skip('unrecognized task types', () => {
taskIdsToRemove.push(notRegisteredTypeId);

// To be sure that the background task that marks removed tasks as unrecognized has run after the tasks were created
const runSoonResponse = await taskManagerPlugin.runSoon('mark_removed_tasks_as_unrecognized');
expect(runSoonResponse).toEqual({ id: 'mark_removed_tasks_as_unrecognized' });
await retry(async () => {
try {
const runSoonResponse = await taskManagerPlugin.runSoon(
'mark_removed_tasks_as_unrecognized'
);
expect(runSoonResponse).toEqual({ id: 'mark_removed_tasks_as_unrecognized' });
} catch (err) {
// ignore errors and retry
}
});

await retry(async () => {
const task = await getTask(kibanaServer.coreStart.elasticsearch.client.asInternalUser);
Expand Down