Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types #210399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Failed CI StepsMetrics [docs]
History
cc @ymao1 |
|
@elasticmachine merge upstream |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
approved these changes
Feb 11, 2025
| } catch (err) { | ||
| // it's possible the task is already running, so catch those errors and retry | ||
| // otherwise throw | ||
| if (!err.message.includes('as it is currently running')) { |
There was a problem hiding this comment.
should we bother checking this? Wondering if this will get flaky if an error message changes in the future ...
There was a problem hiding this comment.
Sure, I can remove and we can retry in the case of any error.
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13287701882 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…ared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (elastic#210399) Resolves elastic#208459 ## Summary The fix added in this [PR](elastic#206598) to call the `mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if the task is in the middle of running. This PR adds a try/catch and a retry to the `runSoon` call. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5500eab)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…ared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (elastic#210399) Resolves elastic#208459 ## Summary The fix added in this [PR](elastic#206598) to call the `mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if the task is in the middle of running. This PR adds a try/catch and a retry to the `runSoon` call. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5500eab)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…ared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (elastic#210399) Resolves elastic#208459 ## Summary The fix added in this [PR](elastic#206598) to call the `mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if the task is in the middle of running. This PR adds a try/catch and a retry to the `runSoon` call. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 5500eab)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…gins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399) (#210842) # Backport This will backport the following commits from `main` to `8.18`: - [Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)](#210399) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T14:30:38Z","message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types","number":210399,"url":"https://github.com/elastic/kibana/pull/210399","mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210399","number":210399,"mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…ins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399) (#210843) # Backport This will backport the following commits from `main` to `8.x`: - [Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)](#210399) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T14:30:38Z","message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types","number":210399,"url":"https://github.com/elastic/kibana/pull/210399","mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210399","number":210399,"mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…ins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399) (#210844) # Backport This will backport the following commits from `main` to `9.0`: - [Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)](#210399) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T14:30:38Z","message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types","number":210399,"url":"https://github.com/elastic/kibana/pull/210399","mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210399","number":210399,"mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/platform/plugins/shared/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#210399)\n\nResolves https://github.com/elastic/kibana/issues/208459\r\n\r\n## Summary\r\n\r\nThe fix added in this\r\n[PR](#206598) to call the\r\n`mark_removed_tasks_as_unrecognized` tasks sometimes throws an error if\r\nthe task is in the middle of running. This PR adds a try/catch and a\r\nretry to the `runSoon` call.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"5500eab90ca7053a7741f9274e3886f4a7460228"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <ying.mao@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #208459
Summary
The fix added in this PR to call the
mark_removed_tasks_as_unrecognizedtasks sometimes throws an error if the task is in the middle of running. This PR adds a try/catch and a retry to therunSooncall.