-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option #209350
[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option #209350
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't fix the problem entirely though, the preferred methods show only agentless supported options (direct and temp access key) when for agent-based we have 4 manual methods and one automated (eg. Cloudformation for AWS)
tested after the second commit, now it's working as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM 🚀
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13122294462 |
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13122500194 |
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13122601282 |
…ntegrations with agentless as a deployment option (elastic#209350) (cherry picked from commit dff20a6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… for integrations with agentless as a deployment option (#209350) (#209415) # Backport This will backport the following commits from `main` to `8.x`: - [[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)](#209350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
…m for integrations with agentless as a deployment option (#209350) (#209414) # Backport This will backport the following commits from `main` to `8.18`: - [[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)](#209350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
… for integrations with agentless as a deployment option (#209350) (#209416) # Backport This will backport the following commits from `main` to `9.0`: - [[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)](#209350) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option (#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
Summary
Fixes [Bug] Agent-based deployment selections are not showing on prem for integrations with agentless option
Before

After


Checklist
Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.