Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option #209350

Merged

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Feb 3, 2025

Summary

Fixes [Bug] Agent-based deployment selections are not showing on prem for integrations with agentless option

Before
image

After
Screenshot 2025-02-03 at 11 01 12 AM
Screenshot 2025-02-03 at 11 00 52 AM

Checklist

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@seanrathier seanrathier added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 3, 2025
@seanrathier seanrathier self-assigned this Feb 3, 2025
@seanrathier seanrathier requested a review from a team as a code owner February 3, 2025 15:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@seanrathier seanrathier changed the title [Bug] fix showing agent-based deployment options when on-prem [Bug] Agent-based deployment selections are not showing on prem for integrations with agentless as a deployment option Feb 3, 2025
@seanrathier seanrathier requested a review from a team as a code owner February 3, 2025 16:21
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the problem entirely though, the preferred methods show only agentless supported options (direct and temp access key) when for agent-based we have 4 manual methods and one automated (eg. Cloudformation for AWS)

@seanrathier seanrathier added backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development backport labels Feb 3, 2025
@maxcold maxcold self-requested a review February 3, 2025 16:57
@maxcold
Copy link
Contributor

maxcold commented Feb 3, 2025

tested after the second commit, now it's working as expected

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀

@seanrathier seanrathier merged commit dff20a6 into elastic:main Feb 3, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13122294462

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- Update dependency moment-timezone to ^0.5.47 (main) (#208526)
- [Vega] Fix highlight for HJSON (#208858)
- [EDR Workflows] Fix invalid event filter for cloud workloads (#208974)
- [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)
- [SecuritySolution][Endpoint] Update request docs for isolate/release/processes (#209097)
8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)
- [SecuritySolution][Endpoint] Update request docs for isolate/release/processes (#209097)
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 209350

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13122500194

@seanrathier seanrathier removed backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development labels Feb 3, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- Update dependency moment-timezone to ^0.5.47 (main) (#208526)
- [Vega] Fix highlight for HJSON (#208858)
- [EDR Workflows] Fix invalid event filter for cloud workloads (#208974)
- [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)
- [SecuritySolution][Endpoint] Update request docs for isolate/release/processes (#209097)
8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- [Custom threshold] Fix using data view runtime fields during rule execution for the custom threshold rule (#209133)
- [SecuritySolution][Endpoint] Update request docs for isolate/release/processes (#209097)
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 209350

Questions ?

Please refer to the Backport tool documentation

@seanrathier seanrathier added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport:version Backport to applied version labels 8.18 candidate 9.1 candidate 9.0 candidate 8.19 candidate labels Feb 3, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13122601282

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 3, 2025
…ntegrations with agentless as a deployment option (elastic#209350)

(cherry picked from commit dff20a6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 3, 2025
… for integrations with agentless as a deployment option (#209350) (#209415)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Bug] Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)](#209350)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud
Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment
option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}]
BACKPORT-->

Co-authored-by: seanrathier <sean.rathier@gmail.com>
kibanamachine added a commit that referenced this pull request Feb 3, 2025
…m for integrations with agentless as a deployment option (#209350) (#209414)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Bug] Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)](#209350)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud
Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment
option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}]
BACKPORT-->

Co-authored-by: seanrathier <sean.rathier@gmail.com>
kibanamachine added a commit that referenced this pull request Feb 3, 2025
… for integrations with agentless as a deployment option (#209350) (#209416)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Bug] Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)](#209350)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-02-03T20:31:26Z","message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","Team:Fleet","Team:Cloud
Security","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment
option","number":209350,"url":"https://github.com/elastic/kibana/pull/209350","mergeCommit":{"message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209350","number":209350,"mergeCommit":{"message":"[Bug]
Agent-based deployment selections are not showing on prem for
integrations with agentless as a deployment option
(#209350)","sha":"dff20a63c48cfc89c740fd8b3eea47f29b15f79f"}}]}]
BACKPORT-->

Co-authored-by: seanrathier <sean.rathier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants