[EDR Workflows] Fix invalid event filter for cloud workloads #208974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
paul-tavares
approved these changes
Jan 30, 2025
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| import * as t from 'io-ts'; | |||
|
|
|||
| export const meta = t.object; | |||
| export const meta = t.UnknownRecord; | |||
There was a problem hiding this comment.
This is awesome. Thanks for digging into it and ensuring the type is properly defined.
|
@elasticmachine merge upstream |
szwarckonrad
approved these changes
Jan 31, 2025
|
@elasticmachine merge upstream |
vitaliidm
approved these changes
Jan 31, 2025
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
|
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13114342150 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…#208974) ## Summary Fixes the bug of the invalid event filter created automatically when creating a cloud workloads endpoint integration. The issue was a type issue: `undefined` or an object is expected, instead an array was passed. To make sure this does not happen again, the type for the `meta` field was updated from the deprecated `t.object` to `t.UnknownRecord`, which is able to catch similar issues as a type error: ca0c01b ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 158a077)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…#208974) ## Summary Fixes the bug of the invalid event filter created automatically when creating a cloud workloads endpoint integration. The issue was a type issue: `undefined` or an object is expected, instead an array was passed. To make sure this does not happen again, the type for the `meta` field was updated from the deprecated `t.object` to `t.UnknownRecord`, which is able to catch similar issues as a type error: ca0c01b ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 158a077)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…#208974) ## Summary Fixes the bug of the invalid event filter created automatically when creating a cloud workloads endpoint integration. The issue was a type issue: `undefined` or an object is expected, instead an array was passed. To make sure this does not happen again, the type for the `meta` field was updated from the deprecated `t.object` to `t.UnknownRecord`, which is able to catch similar issues as a type error: ca0c01b ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 158a077)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…#208974) ## Summary Fixes the bug of the invalid event filter created automatically when creating a cloud workloads endpoint integration. The issue was a type issue: `undefined` or an object is expected, instead an array was passed. To make sure this does not happen again, the type for the `meta` field was updated from the deprecated `t.object` to `t.UnknownRecord`, which is able to catch similar issues as a type error: ca0c01b ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 158a077)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gergoabraham
added a commit
to gergoabraham/kibana
that referenced
this pull request
Feb 3, 2025
…#208974) ## Summary Fixes the bug of the invalid event filter created automatically when creating a cloud workloads endpoint integration. The issue was a type issue: `undefined` or an object is expected, instead an array was passed. To make sure this does not happen again, the type for the `meta` field was updated from the deprecated `t.object` to `t.UnknownRecord`, which is able to catch similar issues as a type error: ca0c01b ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 158a077) # Conflicts: # x-pack/plugins/security_solution/server/fleet_integration/fleet_integration.test.ts
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…208974) (#209288) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)](#208974) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T13:15:17Z","message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix invalid event filter for cloud workloads","number":208974,"url":"https://github.com/elastic/kibana/pull/208974","mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208974","number":208974,"mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…208974) (#209284) # Backport This will backport the following commits from `main` to `8.17`: - [[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)](#208974) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T13:15:17Z","message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix invalid event filter for cloud workloads","number":208974,"url":"https://github.com/elastic/kibana/pull/208974","mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208974","number":208974,"mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…208974) (#209285) # Backport This will backport the following commits from `main` to `8.18`: - [[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)](#208974) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T13:15:17Z","message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix invalid event filter for cloud workloads","number":208974,"url":"https://github.com/elastic/kibana/pull/208974","mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208974","number":208974,"mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…208974) (#209290) # Backport This will backport the following commits from `main` to `9.0`: - [[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)](#208974) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T13:15:17Z","message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix invalid event filter for cloud workloads","number":208974,"url":"https://github.com/elastic/kibana/pull/208974","mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208974","number":208974,"mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
4 tasks
gergoabraham
added a commit
that referenced
this pull request
Feb 4, 2025
…208974) (#209330) # Backport This will backport the following commits from `main` to `8.16`: - [[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)](#208974) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T13:15:17Z","message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[EDR Workflows] Fix invalid event filter for cloud workloads","number":208974,"url":"https://github.com/elastic/kibana/pull/208974","mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208974","number":208974,"mergeCommit":{"message":"[EDR Workflows] Fix invalid event filter for cloud workloads (#208974)\n\n## Summary\r\n\r\nFixes the bug of the invalid event filter created automatically when\r\ncreating a cloud workloads endpoint integration. The issue was a type\r\nissue: `undefined` or an object is expected, instead an array was\r\npassed.\r\n\r\nTo make sure this does not happen again, the type for the `meta` field\r\nwas updated from the deprecated `t.object` to `t.UnknownRecord`, which\r\nis able to catch similar issues as a type error:\r\nca0c01b63beb40fb19188deae2257d89d8b3ba90\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"158a0777319175b64311c3344dc5cf12e1e6ccc7"}},{"url":"https://github.com/elastic/kibana/pull/209284","number":209284,"branch":"8.17","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/209285","number":209285,"branch":"8.18","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/209288","number":209288,"branch":"8.x","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/209290","number":209290,"branch":"9.0","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug of the invalid event filter created automatically when creating a cloud workloads endpoint integration. The issue was a type issue:
undefinedor an object is expected, instead an array was passed.To make sure this does not happen again, the type for the
metafield was updated from the deprecatedt.objecttot.UnknownRecord, which is able to catch similar issues as a type error: ca0c01bChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.