[Security Solution] Adds ownership to the common API tasks on Cypress #209303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting backport for target branches: 8.18, 9.0 https://github.com/elastic/kibana/actions/runs/13120242998 |
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…elastic#209303) ## Summary The other day when the elastic#208546 was opened, no required review was triggered for the changes in `x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`. This is a problem, since any change in that file can have a huge impact in the overall Cypress test suite. In this PR we are adding security engineering productivity as owners of that file to make sure that changes there are properly reviewed. (cherry picked from commit 802fdf0)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…elastic#209303) ## Summary The other day when the elastic#208546 was opened, no required review was triggered for the changes in `x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`. This is a problem, since any change in that file can have a huge impact in the overall Cypress test suite. In this PR we are adding security engineering productivity as owners of that file to make sure that changes there are properly reviewed. (cherry picked from commit 802fdf0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…ypress (#209303) (#209397) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)](#209303) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gloria Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T18:27:01Z","message":"[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)\n\n## Summary\r\n\r\nThe other day when the #208546 was\r\nopened, no required review was triggered for the changes in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis is a problem, since any change in that file can have a huge impact\r\nin the overall Cypress test suite.\r\n\r\nIn this PR we are adding security engineering productivity as owners of\r\nthat file to make sure that changes there are properly reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","Team: Sec Eng Productivity","v8.18.0","v9.1.0"],"title":"[Security Solution] Adds ownership to the common API tasks on Cypress","number":209303,"url":"https://github.com/elastic/kibana/pull/209303","mergeCommit":{"message":"[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)\n\n## Summary\r\n\r\nThe other day when the #208546 was\r\nopened, no required review was triggered for the changes in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis is a problem, since any change in that file can have a huge impact\r\nin the overall Cypress test suite.\r\n\r\nIn this PR we are adding security engineering productivity as owners of\r\nthat file to make sure that changes there are properly reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209303","number":209303,"mergeCommit":{"message":"[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)\n\n## Summary\r\n\r\nThe other day when the #208546 was\r\nopened, no required review was triggered for the changes in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis is a problem, since any change in that file can have a huge impact\r\nin the overall Cypress test suite.\r\n\r\nIn this PR we are adding security engineering productivity as owners of\r\nthat file to make sure that changes there are properly reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2"}}]}] BACKPORT--> Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2025
…Cypress (#209303) (#209396) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)](#209303) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gloria Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T18:27:01Z","message":"[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)\n\n## Summary\r\n\r\nThe other day when the #208546 was\r\nopened, no required review was triggered for the changes in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis is a problem, since any change in that file can have a huge impact\r\nin the overall Cypress test suite.\r\n\r\nIn this PR we are adding security engineering productivity as owners of\r\nthat file to make sure that changes there are properly reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","Team: Sec Eng Productivity","v8.18.0","v9.1.0"],"title":"[Security Solution] Adds ownership to the common API tasks on Cypress","number":209303,"url":"https://github.com/elastic/kibana/pull/209303","mergeCommit":{"message":"[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)\n\n## Summary\r\n\r\nThe other day when the #208546 was\r\nopened, no required review was triggered for the changes in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis is a problem, since any change in that file can have a huge impact\r\nin the overall Cypress test suite.\r\n\r\nIn this PR we are adding security engineering productivity as owners of\r\nthat file to make sure that changes there are properly reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209303","number":209303,"mergeCommit":{"message":"[Security Solution] Adds ownership to the common API tasks on Cypress (#209303)\n\n## Summary\r\n\r\nThe other day when the #208546 was\r\nopened, no required review was triggered for the changes in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis is a problem, since any change in that file can have a huge impact\r\nin the overall Cypress test suite.\r\n\r\nIn this PR we are adding security engineering productivity as owners of\r\nthat file to make sure that changes there are properly reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2"}}]}] BACKPORT--> Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The other day when the #208546 was opened, no required review was triggered for the changes in
x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts.This is a problem, since any change in that file can have a huge impact in the overall Cypress test suite.
In this PR we are adding security engineering productivity as owners of that file to make sure that changes there are properly reviewed.