Skip to content

Commit

Permalink
[8.18] [Security Solution] Adds ownership to the common API tasks on …
Browse files Browse the repository at this point in the history
…Cypress (#209303) (#209396)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution] Adds ownership to the common API tasks on Cypress
(#209303)](#209303)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2025-02-03T18:27:01Z","message":"[Security
Solution] Adds ownership to the common API tasks on Cypress
(#209303)\n\n## Summary\r\n\r\nThe other day when the
#208546 was\r\nopened, no required
review was triggered for the changes
in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis
is a problem, since any change in that file can have a huge impact\r\nin
the overall Cypress test suite.\r\n\r\nIn this PR we are adding security
engineering productivity as owners of\r\nthat file to make sure that
changes there are properly
reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","Team:
Sec Eng Productivity","v8.18.0","v9.1.0"],"title":"[Security Solution]
Adds ownership to the common API tasks on
Cypress","number":209303,"url":"https://github.com/elastic/kibana/pull/209303","mergeCommit":{"message":"[Security
Solution] Adds ownership to the common API tasks on Cypress
(#209303)\n\n## Summary\r\n\r\nThe other day when the
#208546 was\r\nopened, no required
review was triggered for the changes
in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis
is a problem, since any change in that file can have a huge impact\r\nin
the overall Cypress test suite.\r\n\r\nIn this PR we are adding security
engineering productivity as owners of\r\nthat file to make sure that
changes there are properly
reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209303","number":209303,"mergeCommit":{"message":"[Security
Solution] Adds ownership to the common API tasks on Cypress
(#209303)\n\n## Summary\r\n\r\nThe other day when the
#208546 was\r\nopened, no required
review was triggered for the changes
in\r\n`x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts`.\r\n\r\nThis
is a problem, since any change in that file can have a huge impact\r\nin
the overall Cypress test suite.\r\n\r\nIn this PR we are adding security
engineering productivity as owners of\r\nthat file to make sure that
changes there are properly
reviewed.","sha":"802fdf0cf2e6d80044cd139696d9da63a07733a2"}}]}]
BACKPORT-->

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
  • Loading branch information
kibanamachine and MadameSheema authored Feb 3, 2025
1 parent 1cae919 commit 21be576
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2217,6 +2217,7 @@ x-pack/test/security_solution_api_integration/test_suites/sources @elastic/secur
/x-pack/test/security_solution_cypress/* @elastic/security-engineering-productivity
/x-pack/test/security_solution_cypress/cypress/* @elastic/security-engineering-productivity
/x-pack/test/security_solution_cypress/cypress/tasks/login.ts @elastic/security-engineering-productivity
/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/common.ts @elastic/security-engineering-productivity
/x-pack/test/security_solution_cypress/es_archives @elastic/security-engineering-productivity
/x-pack/test/security_solution_playwright @elastic/security-engineering-productivity
/x-pack/solutions/security/plugins/security_solution/scripts/run_cypress @MadameSheema @patrykkopycinski @maximpn @banderror
Expand Down

0 comments on commit 21be576

Please sign in to comment.