Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rules migration] Inlined ES|QL editor #208497

Merged
merged 5 commits into from
Jan 28, 2025
Merged

[Rules migration] Inlined ES|QL editor #208497

merged 5 commits into from
Jan 28, 2025
+2 −0

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Jan 28, 2025 •
edited by kibanamachine
Loading

Summary

With these changes we make ES|QL editor inlined which increases the default height of it.

This is possible after we allowed the ES|QL editor to hide "run query" button when inlined prop is used #208446

Screenshot 2025-01-27 at 21 31 24

Note

This feature needs siemMigrationsEnabled experimental flag enabled to work.

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 28, 2025
@e40pud e40pud requested a review from semd January 28, 2025 09:48
@e40pud e40pud self-assigned this Jan 28, 2025
@e40pud e40pud requested a review from a team as a code owner January 28, 2025 09:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@e40pud e40pud enabled auto-merge (squash) January 28, 2025 13:41
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #68 / Cloud Security Posture Agentless Security Posture Integration Options should show cspm with agentless option
  • [job] [logs] FTR Configs #68 / Cloud Security Posture Agentless Security Posture Integration Options should show cspm with agentless option

History

cc @e40pud

@e40pud e40pud merged commit 9a5df11 into elastic:main Jan 28, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13017726637

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 28, 2025
@e40pud
[Rules migration] Inlined ES|QL editor (elastic#208497)
cf401e2 
## Summary

With these changes we make ES|QL editor inlined which increases the
default height of it.

This is possible after we allowed the ES|QL editor to hide "run query"
button when inlined prop is used
elastic#208446

<img width="1281" alt="Screenshot 2025-01-27 at 21 31 24"
src="https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f"
/>

> [!NOTE]
> This feature needs `siemMigrationsEnabled` experimental flag enabled
to work.

(cherry picked from commit 9a5df11)
@kibanamachine kibanamachine mentioned this pull request Jan 28, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 28, 2025
@kibanamachine @e40pud
[8.x] [Rules migration] Inlined ES|QL editor (#208497) (#208607)
c4d073e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Rules migration] Inlined ES|QL editor
(#208497)](#208497)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T19:07:36Z","message":"[Rules
migration] Inlined ES|QL editor (#208497)\n\n## Summary\r\n\r\nWith
these changes we make ES|QL editor inlined which increases
the\r\ndefault height of it.\r\n\r\nThis is possible after we allowed
the ES|QL editor to hide \"run query\"\r\nbutton when inlined prop is
used\r\nhttps://github.com//pull/208446\r\n\r\n<img
width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31
24\"\r\nsrc=\"https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f\"\r\n/>\r\n\r\n>
[!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental
flag enabled\r\nto
work.","sha":"9a5df11b33fa7848e29ef777e5b1abd31fadd257","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules
migration] Inlined ES|QL
editor","number":208497,"url":"https://github.com/elastic/kibana/pull/208497","mergeCommit":{"message":"[Rules
migration] Inlined ES|QL editor (#208497)\n\n## Summary\r\n\r\nWith
these changes we make ES|QL editor inlined which increases
the\r\ndefault height of it.\r\n\r\nThis is possible after we allowed
the ES|QL editor to hide \"run query\"\r\nbutton when inlined prop is
used\r\nhttps://github.com//pull/208446\r\n\r\n<img
width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31
24\"\r\nsrc=\"https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f\"\r\n/>\r\n\r\n>
[!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental
flag enabled\r\nto
work.","sha":"9a5df11b33fa7848e29ef777e5b1abd31fadd257"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208497","number":208497,"mergeCommit":{"message":"[Rules
migration] Inlined ES|QL editor (#208497)\n\n## Summary\r\n\r\nWith
these changes we make ES|QL editor inlined which increases
the\r\ndefault height of it.\r\n\r\nThis is possible after we allowed
the ES|QL editor to hide \"run query\"\r\nbutton when inlined prop is
used\r\nhttps://github.com//pull/208446\r\n\r\n<img
width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31
24\"\r\nsrc=\"https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f\"\r\n/>\r\n\r\n>
[!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental
flag enabled\r\nto
work.","sha":"9a5df11b33fa7848e29ef777e5b1abd31fadd257"}}]}] BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e40pud @elasticmachine @kibanamachine @semd