[ES|QL Editor] Add hideRunQueryButton prop to control run query button visibility
#208446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsAPI count
cc @e40pud |
stratoula
approved these changes
Jan 28, 2025
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13006389341 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
…ton visibility (elastic#208446) ## Summary Working on "SIEM Migrations" we needed to be able to have a bigger height for the ES|QL editor. To achive that we could use `editorIsInline` prop which extends the height of the editor, though it would expose "run query" button. The "run query" button does not fit the the UI of the "SIEM Migrations" feature, so we added the new prop `hideRunQueryButton` to be able to hide the "run query" button. More details in [slack](https://elastic.slack.com/archives/C06RG9MTZMJ/p1737996842482479). ### Screenshot of the inlined ES|QL editor within "SIEM Migrations" feature <img width="1281" alt="Screenshot 2025-01-27 at 21 31 24" src="https://github.com/user-attachments/assets/4b6f1917-c7f0-4a73-9e3b-912257d6d825" /> (cherry picked from commit 34092ec)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…ol run query button visibility (#208446) (#208487) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL Editor] Add `hideRunQueryButton` prop to control run query button visibility (#208446)](#208446) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T08:27:49Z","message":"[ES|QL Editor] Add `hideRunQueryButton` prop to control run query button visibility (#208446)\n\n## Summary\r\n\r\nWorking on \"SIEM Migrations\" we needed to be able to have a bigger\r\nheight for the ES|QL editor. To achive that we could use\r\n`editorIsInline` prop which extends the height of the editor, though it\r\nwould expose \"run query\" button. The \"run query\" button does not fit the\r\nthe UI of the \"SIEM Migrations\" feature, so we added the new prop\r\n`hideRunQueryButton` to be able to hide the \"run query\" button. More\r\ndetails in\r\n[slack](https://elastic.slack.com/archives/C06RG9MTZMJ/p1737996842482479).\r\n\r\n### Screenshot of the inlined ES|QL editor within \"SIEM Migrations\"\r\nfeature\r\n\r\n<img width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31 24\"\r\nsrc=\"https://github.com/user-attachments/assets/4b6f1917-c7f0-4a73-9e3b-912257d6d825\"\r\n/>","sha":"34092ec953b95341c7c8a2f6478b99288bbdb405","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"title":"[ES|QL Editor] Add `hideRunQueryButton` prop to control run query button visibility","number":208446,"url":"https://github.com/elastic/kibana/pull/208446","mergeCommit":{"message":"[ES|QL Editor] Add `hideRunQueryButton` prop to control run query button visibility (#208446)\n\n## Summary\r\n\r\nWorking on \"SIEM Migrations\" we needed to be able to have a bigger\r\nheight for the ES|QL editor. To achive that we could use\r\n`editorIsInline` prop which extends the height of the editor, though it\r\nwould expose \"run query\" button. The \"run query\" button does not fit the\r\nthe UI of the \"SIEM Migrations\" feature, so we added the new prop\r\n`hideRunQueryButton` to be able to hide the \"run query\" button. More\r\ndetails in\r\n[slack](https://elastic.slack.com/archives/C06RG9MTZMJ/p1737996842482479).\r\n\r\n### Screenshot of the inlined ES|QL editor within \"SIEM Migrations\"\r\nfeature\r\n\r\n<img width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31 24\"\r\nsrc=\"https://github.com/user-attachments/assets/4b6f1917-c7f0-4a73-9e3b-912257d6d825\"\r\n/>","sha":"34092ec953b95341c7c8a2f6478b99288bbdb405"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208446","number":208446,"mergeCommit":{"message":"[ES|QL Editor] Add `hideRunQueryButton` prop to control run query button visibility (#208446)\n\n## Summary\r\n\r\nWorking on \"SIEM Migrations\" we needed to be able to have a bigger\r\nheight for the ES|QL editor. To achive that we could use\r\n`editorIsInline` prop which extends the height of the editor, though it\r\nwould expose \"run query\" button. The \"run query\" button does not fit the\r\nthe UI of the \"SIEM Migrations\" feature, so we added the new prop\r\n`hideRunQueryButton` to be able to hide the \"run query\" button. More\r\ndetails in\r\n[slack](https://elastic.slack.com/archives/C06RG9MTZMJ/p1737996842482479).\r\n\r\n### Screenshot of the inlined ES|QL editor within \"SIEM Migrations\"\r\nfeature\r\n\r\n<img width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31 24\"\r\nsrc=\"https://github.com/user-attachments/assets/4b6f1917-c7f0-4a73-9e3b-912257d6d825\"\r\n/>","sha":"34092ec953b95341c7c8a2f6478b99288bbdb405"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
e40pud
added a commit
that referenced
this pull request
Jan 28, 2025
## Summary With these changes we make ES|QL editor inlined which increases the default height of it. This is possible after we allowed the ES|QL editor to hide "run query" button when inlined prop is used #208446 <img width="1281" alt="Screenshot 2025-01-27 at 21 31 24" src="https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f" /> > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
## Summary With these changes we make ES|QL editor inlined which increases the default height of it. This is possible after we allowed the ES|QL editor to hide "run query" button when inlined prop is used elastic#208446 <img width="1281" alt="Screenshot 2025-01-27 at 21 31 24" src="https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f" /> > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. (cherry picked from commit 9a5df11)
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration] Inlined ES|QL editor (#208497)](#208497) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T19:07:36Z","message":"[Rules migration] Inlined ES|QL editor (#208497)\n\n## Summary\r\n\r\nWith these changes we make ES|QL editor inlined which increases the\r\ndefault height of it.\r\n\r\nThis is possible after we allowed the ES|QL editor to hide \"run query\"\r\nbutton when inlined prop is used\r\nhttps://github.com//pull/208446\r\n\r\n<img width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31 24\"\r\nsrc=\"https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f\"\r\n/>\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.","sha":"9a5df11b33fa7848e29ef777e5b1abd31fadd257","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules migration] Inlined ES|QL editor","number":208497,"url":"https://github.com/elastic/kibana/pull/208497","mergeCommit":{"message":"[Rules migration] Inlined ES|QL editor (#208497)\n\n## Summary\r\n\r\nWith these changes we make ES|QL editor inlined which increases the\r\ndefault height of it.\r\n\r\nThis is possible after we allowed the ES|QL editor to hide \"run query\"\r\nbutton when inlined prop is used\r\nhttps://github.com//pull/208446\r\n\r\n<img width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31 24\"\r\nsrc=\"https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f\"\r\n/>\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.","sha":"9a5df11b33fa7848e29ef777e5b1abd31fadd257"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208497","number":208497,"mergeCommit":{"message":"[Rules migration] Inlined ES|QL editor (#208497)\n\n## Summary\r\n\r\nWith these changes we make ES|QL editor inlined which increases the\r\ndefault height of it.\r\n\r\nThis is possible after we allowed the ES|QL editor to hide \"run query\"\r\nbutton when inlined prop is used\r\nhttps://github.com//pull/208446\r\n\r\n<img width=\"1281\" alt=\"Screenshot 2025-01-27 at 21 31 24\"\r\nsrc=\"https://github.com/user-attachments/assets/e44bbe18-538a-411a-bb84-59a080014c8f\"\r\n/>\r\n\r\n> [!NOTE] \r\n> This feature needs `siemMigrationsEnabled` experimental flag enabled\r\nto work.","sha":"9a5df11b33fa7848e29ef777e5b1abd31fadd257"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Working on "SIEM Migrations" we needed to be able to have a bigger height for the ES|QL editor. To achive that we could use
editorIsInlineprop which extends the height of the editor, though it would expose "run query" button. The "run query" button does not fit the the UI of the "SIEM Migrations" feature, so we added the new prophideRunQueryButtonto be able to hide the "run query" button. More details in slack.Screenshot of the inlined ES|QL editor within "SIEM Migrations" feature