🌊 Streams - unskip test debug #208150
Merged
🌊 Streams - unskip test debug #208150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bana into flash1293/unskip-flaky-test
klacabane
approved these changes
Jan 27, 2025
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13008504697 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
Fixes elastic#206482 Fixes elastic#206483 I did some tests running the flaky part in a loop and couldn't get it to fail once both locally and on CI. I also reviewed the code and I can't tell how this could be flaky. My guess is that something changed since we skipped this test. Before spending more time on it, let's try to unskip - if it still causes problems we can quickly skip again. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8bb48a4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Streams - unskip test debug (#208150)](#208150) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"johannes.reuter@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T10:32:10Z","message":"🌊 Streams - unskip test debug (#208150)\n\nFixes https://github.com/elastic/kibana/issues/206482\nFixes https://github.com/elastic/kibana/issues/206483\n\nI did some tests running the flaky part in a loop and couldn't get it to\nfail once both locally and on CI.\nI also reviewed the code and I can't tell how this could be flaky. My\nguess is that something changed since we skipped this test.\n\nBefore spending more time on it, let's try to unskip - if it still\ncauses problems we can quickly skip again.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8bb48a44275a73187f8330bd2c3ad12e6c8edb61","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"🌊 Streams - unskip test debug","number":208150,"url":"https://github.com/elastic/kibana/pull/208150","mergeCommit":{"message":"🌊 Streams - unskip test debug (#208150)\n\nFixes https://github.com/elastic/kibana/issues/206482\nFixes https://github.com/elastic/kibana/issues/206483\n\nI did some tests running the flaky part in a loop and couldn't get it to\nfail once both locally and on CI.\nI also reviewed the code and I can't tell how this could be flaky. My\nguess is that something changed since we skipped this test.\n\nBefore spending more time on it, let's try to unskip - if it still\ncauses problems we can quickly skip again.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8bb48a44275a73187f8330bd2c3ad12e6c8edb61"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208150","number":208150,"mergeCommit":{"message":"🌊 Streams - unskip test debug (#208150)\n\nFixes https://github.com/elastic/kibana/issues/206482\nFixes https://github.com/elastic/kibana/issues/206483\n\nI did some tests running the flaky part in a loop and couldn't get it to\nfail once both locally and on CI.\nI also reviewed the code and I can't tell how this could be flaky. My\nguess is that something changed since we skipped this test.\n\nBefore spending more time on it, let's try to unskip - if it still\ncauses problems we can quickly skip again.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8bb48a44275a73187f8330bd2c3ad12e6c8edb61"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206482
Fixes #206483
I did some tests running the flaky part in a loop and couldn't get it to fail once both locally and on CI.
I also reviewed the code and I can't tell how this could be flaky. My guess is that something changed since we skipped this test.
Before spending more time on it, let's try to unskip - if it still causes problems we can quickly skip again.