Skip to content

Commit

Permalink
[8.x] 🌊 Streams - unskip test debug (#208150) (#208506)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.x`:
- [🌊 Streams - unskip test debug
(#208150)](#208150)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
Reuter","email":"johannes.reuter@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T10:32:10Z","message":"🌊
Streams - unskip test debug (#208150)\n\nFixes
https://github.com/elastic/kibana/issues/206482\nFixes
https://github.com/elastic/kibana/issues/206483\n\nI did some tests
running the flaky part in a loop and couldn't get it to\nfail once both
locally and on CI.\nI also reviewed the code and I can't tell how this
could be flaky. My\nguess is that something changed since we skipped
this test.\n\nBefore spending more time on it, let's try to unskip - if
it still\ncauses problems we can quickly skip
again.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8bb48a44275a73187f8330bd2c3ad12e6c8edb61","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"🌊
Streams - unskip test
debug","number":208150,"url":"https://github.com/elastic/kibana/pull/208150","mergeCommit":{"message":"🌊
Streams - unskip test debug (#208150)\n\nFixes
https://github.com/elastic/kibana/issues/206482\nFixes
https://github.com/elastic/kibana/issues/206483\n\nI did some tests
running the flaky part in a loop and couldn't get it to\nfail once both
locally and on CI.\nI also reviewed the code and I can't tell how this
could be flaky. My\nguess is that something changed since we skipped
this test.\n\nBefore spending more time on it, let's try to unskip - if
it still\ncauses problems we can quickly skip
again.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8bb48a44275a73187f8330bd2c3ad12e6c8edb61"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208150","number":208150,"mergeCommit":{"message":"🌊
Streams - unskip test debug (#208150)\n\nFixes
https://github.com/elastic/kibana/issues/206482\nFixes
https://github.com/elastic/kibana/issues/206483\n\nI did some tests
running the flaky part in a loop and couldn't get it to\nfail once both
locally and on CI.\nI also reviewed the code and I can't tell how this
could be flaky. My\nguess is that something changed since we skipped
this test.\n\nBefore spending more time on it, let's try to unskip - if
it still\ncauses problems we can quickly skip
again.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8bb48a44275a73187f8330bd2c3ad12e6c8edb61"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
  • Loading branch information
kibanamachine and flash1293 authored Jan 28, 2025
1 parent 3ed30a7 commit 1178850
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,9 @@ describe('StorageIndexAdapter', () => {
await verifyClean();
});

// FLAKY: https://github.com/elastic/kibana/issues/206482
// FLAKY: https://github.com/elastic/kibana/issues/206483
describe.skip('after rolling over the index manually and indexing the same document', () => {
describe('after rolling over the index manually and indexing the same document', () => {
beforeAll(async () => {
await verifyClean();
await client.index({ id: 'doc1', document: { foo: 'bar' } });
await rolloverIndex();
await client.index({ id: 'doc1', document: { foo: 'bar' } });
Expand Down

0 comments on commit 1178850

Please sign in to comment.