[8.x] [Dataset Quality] Fix loading on dataset quality summary (#201757) #201937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ## 📓 Summary Closes elastic#186549 Refreshing the page didn't give enough time for the data ingestion to process correctly, hopefully navigating to the page, which is gated by an assertion on loading indicators, should check that data is loaded correctly. Also, running the test in isolation raised a bug in the code, where the loading of the summary details was not synced with the loaded data from the table. This resulted in the summary always being 0 at first load, and then immediately update once the table is ready, which broke the test. Syncing their loading indicators fixed the issue and tests passes in isolation too. --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> (cherry picked from commit 8814e43)
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation