Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dataset_quality/dataset_quality_summary·ts - Dataset Quality Dataset quality summary shows poor, degraded and good count as 0 and all dataset as healthy #186549

Closed
kibanamachine opened this issue Jun 20, 2024 · 5 comments · Fixed by #186618 or #201757
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dataset_quality/dataset_quality_summary·ts - Dataset Quality Dataset quality summary shows poor, degraded and good count as 0 and all dataset as healthy #186549

kibanamachine opened this issue Jun 20, 2024 · 5 comments · Fixed by #186618 or #201757
Assignees
@tonyghiani
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-logs Observability Logs User Experience Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 20, 2024 •
edited
Loading

A test failed on a tracked branch

TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="datasetQualityFiltersContainer"])
Wait timed out after 10031ms
    at /opt/buildkite-agent/builds/bk-agent-prod-gcp-1718899941974624444/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:911:22
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  remoteStacktrace: ''
}

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 20, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 20, 2024
@kibanamachine kibanamachine added the Team:obs-ux-logs Observability Logs User Experience Team label Jun 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 20, 2024
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Jun 21, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@achyutjhunjhunwala achyutjhunjhunwala mentioned this issue Jun 21, 2024
Merged
achyutjhunjhunwala added a commit that referenced this issue Jun 21, 2024
@achyutjhunjhunwala
[Dataset Quality] Fix flaky summary test (#186618)
e9a224d 
## Summary

Closes #186549
bhapas pushed a commit to bhapas/kibana that referenced this issue Jun 24, 2024
@achyutjhunjhunwala @bhapas
[Dataset Quality] Fix flaky summary test (elastic#186618)
abbd938 
## Summary

Closes elastic#186549
@kibanamachine kibanamachine reopened this Nov 19, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

@weltenwort
Copy link
Member

I was unable to reproduce this locally so far

@weltenwort weltenwort removed their assignment Nov 20, 2024
@yngrdyn
Copy link
Contributor

yngrdyn commented Nov 20, 2024

From what I see in the screenshot, maybe the environment was super slow when the test ran

@tonyghiani tonyghiani self-assigned this Nov 26, 2024
@tonyghiani tonyghiani mentioned this issue Nov 26, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 27, 2024
@tonyghiani
[Dataset Quality] Fix loading on dataset quality summary (elastic#201757
6f92590 
)

## 📓 Summary

Closes elastic#186549

Refreshing the page didn't give enough time for the data ingestion to
process correctly, hopefully navigating to the page, which is gated by
an assertion on loading indicators, should check that data is loaded
correctly.

Also, running the test in isolation raised a bug in the code, where the
loading of the summary details was not synced with the loaded data from
the table. This resulted in the summary always being 0 at first load,
and then immediately update once the table is ready, which broke the
test. Syncing their loading indicators fixed the issue and tests passes
in isolation too.

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
(cherry picked from commit 8814e43)
kibanamachine added a commit that referenced this issue Nov 27, 2024
@kibanamachine @tonyghiani
[8.x] [Dataset Quality] Fix loading on dataset quality summary (#201757…
7b21abd 
…) (#201937)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Fix loading on dataset quality summary
(#201757)](#201757)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-11-27T10:39:23Z","message":"[Dataset
Quality] Fix loading on dataset quality summary (#201757)\n\n## 📓
Summary\r\n\r\nCloses #186549 \r\n\r\nRefreshing the page didn't give
enough time for the data ingestion to\r\nprocess correctly, hopefully
navigating to the page, which is gated by\r\nan assertion on loading
indicators, should check that data is loaded\r\ncorrectly.\r\n\r\nAlso,
running the test in isolation raised a bug in the code, where
the\r\nloading of the summary details was not synced with the loaded
data from\r\nthe table. This resulted in the summary always being 0 at
first load,\r\nand then immediately update once the table is ready,
which broke the\r\ntest. Syncing their loading indicators fixed the
issue and tests passes\r\nin isolation
too.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"8814e430e757dd6b3ec1ffec6eaa394e16d36cbd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Dataset
Quality] Fix loading on dataset quality
summary","number":201757,"url":"https://github.com/elastic/kibana/pull/201757","mergeCommit":{"message":"[Dataset
Quality] Fix loading on dataset quality summary (#201757)\n\n## 📓
Summary\r\n\r\nCloses #186549 \r\n\r\nRefreshing the page didn't give
enough time for the data ingestion to\r\nprocess correctly, hopefully
navigating to the page, which is gated by\r\nan assertion on loading
indicators, should check that data is loaded\r\ncorrectly.\r\n\r\nAlso,
running the test in isolation raised a bug in the code, where
the\r\nloading of the summary details was not synced with the loaded
data from\r\nthe table. This resulted in the summary always being 0 at
first load,\r\nand then immediately update once the table is ready,
which broke the\r\ntest. Syncing their loading indicators fixed the
issue and tests passes\r\nin isolation
too.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"8814e430e757dd6b3ec1ffec6eaa394e16d36cbd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201757","number":201757,"mergeCommit":{"message":"[Dataset
Quality] Fix loading on dataset quality summary (#201757)\n\n## 📓
Summary\r\n\r\nCloses #186549 \r\n\r\nRefreshing the page didn't give
enough time for the data ingestion to\r\nprocess correctly, hopefully
navigating to the page, which is gated by\r\nan assertion on loading
indicators, should check that data is loaded\r\ncorrectly.\r\n\r\nAlso,
running the test in isolation raised a bug in the code, where
the\r\nloading of the summary details was not synced with the loaded
data from\r\nthe table. This resulted in the summary always being 0 at
first load,\r\nand then immediately update once the table is ready,
which broke the\r\ntest. Syncing their loading indicators fixed the
issue and tests passes\r\nin isolation
too.\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"8814e430e757dd6b3ec1ffec6eaa394e16d36cbd"}}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@tonyghiani @CAWilson94
[Dataset Quality] Fix loading on dataset quality summary (elastic#201757
222d53a 
)

## 📓 Summary

Closes elastic#186549 

Refreshing the page didn't give enough time for the data ingestion to
process correctly, hopefully navigating to the page, which is gated by
an assertion on loading indicators, should check that data is loaded
correctly.

Also, running the test in isolation raised a bug in the code, where the
loading of the summary details was not synced with the loaded data from
the table. This resulted in the summary always being 0 at first load,
and then immediately update once the table is ready, which broke the
test. Syncing their loading indicators fixed the issue and tests passes
in isolation too.

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
6 participants
@weltenwort @yngrdyn @achyutjhunjhunwala @elasticmachine @tonyghiani @kibanamachine