Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts #201533

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts #201533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
217eca1
test: skip mki failing test
rmyz Nov 25, 2024
ab451c9
fix: fix tag
rmyz Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...eployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
return response.body as TransactionsGroupsMainStatistics;
}

describe('Transaction groups alerts', () => {
describe('Transaction groups alerts', function () {
// fails on MKI, see https://github.com/elastic/kibana/issues/201531
this.tags(['failsOnMKI']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should see if we can fix this instead of skipping it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can come up with a short-term fix today, then this would definitely preferable. If it takes longer than that, we'll have to temporarily skip the tests for MKI execution in order to unblock the pipeline which is also used for serverless releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, let's try to unblock this as soon as possible and I'll keep working on the issue to remove the skip part.


describe('when data is loaded', () => {
const transactions = [
{
Expand Down