Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts #201533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
pheyos
reviewed
Nov 25, 2024
...n/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts
Outdated
Show resolved
Hide resolved
crespocarlos
requested changes
Nov 25, 2024
| describe('Transaction groups alerts', () => { | ||
| describe('Transaction groups alerts', function () { | ||
| // fails on MKI, see https://github.com/elastic/kibana/issues/201531 | ||
| this.tags(['failsOnMKI']); |
There was a problem hiding this comment.
We should see if we can fix this instead of skipping it.
There was a problem hiding this comment.
If you can come up with a short-term fix today, then this would definitely preferable. If it takes longer than that, we'll have to temporarily skip the tests for MKI execution in order to unblock the pipeline which is also used for serverless releases.
There was a problem hiding this comment.
Definitely, let's try to unblock this as soon as possible and I'll keep working on the issue to remove the skip part.
💚 Build Succeeded
Metrics [docs]
cc @rmyz |
crespocarlos
approved these changes
Nov 25, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12010366645 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
…g transaction duration alerts returns the correct number of alert counts (elastic#201533) ## Summary Related to elastic#201531 This PR skips `Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts`, which is inside `x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts` file, as it's failing on MKI. (cherry picked from commit a76084f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
…ith avg transaction duration alerts returns the correct number of alert counts (#201533) (#201578) # Backport This will backport the following commits from `main` to `8.x`: - [Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts (#201533)](#201533) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2024-11-25T12:48:31Z","message":"Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts (#201533)\n\n## Summary\nRelated to https://github.com/elastic/kibana/issues/201531\n\nThis PR skips `Transaction groups alerts when data is loaded with avg\ntransaction duration alerts returns the correct number of alert counts`,\nwhich is inside\n`x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts`\nfile, as it's failing on MKI.","sha":"a76084f30f8bc4b59deb2efef7b653bafe13c06c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts","number":201533,"url":"https://github.com/elastic/kibana/pull/201533","mergeCommit":{"message":"Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts (#201533)\n\n## Summary\nRelated to https://github.com/elastic/kibana/issues/201531\n\nThis PR skips `Transaction groups alerts when data is loaded with avg\ntransaction duration alerts returns the correct number of alert counts`,\nwhich is inside\n`x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts`\nfile, as it's failing on MKI.","sha":"a76084f30f8bc4b59deb2efef7b653bafe13c06c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201533","number":201533,"mergeCommit":{"message":"Skip Serverless Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts (#201533)\n\n## Summary\nRelated to https://github.com/elastic/kibana/issues/201531\n\nThis PR skips `Transaction groups alerts when data is loaded with avg\ntransaction duration alerts returns the correct number of alert counts`,\nwhich is inside\n`x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts`\nfile, as it's failing on MKI.","sha":"a76084f30f8bc4b59deb2efef7b653bafe13c06c"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…g transaction duration alerts returns the correct number of alert counts (elastic#201533) ## Summary Related to elastic#201531 This PR skips `Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts`, which is inside `x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts` file, as it's failing on MKI.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…g transaction duration alerts returns the correct number of alert counts (elastic#201533) ## Summary Related to elastic#201531 This PR skips `Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts`, which is inside `x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.ts` file, as it's failing on MKI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #201531
This PR skips
Transaction groups alerts when data is loaded with avg transaction duration alerts returns the correct number of alert counts, which is insidex-pack/test/api_integration/deployment_agnostic/apis/observability/apm/transactions/transactions_groups_alerts.spec.tsfile, as it's failing on MKI.A proper fix will be implemented soon in the issue.