Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Update function definitions #184626

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

kibanamachine
Copy link
Contributor

This PR updates the function definitions based on the latest metadata from Elasticsearch.

@kibanamachine kibanamachine added release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana labels Jun 3, 2024
@kibanamachine kibanamachine requested a review from a team as a code owner June 3, 2024 04:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon
Copy link
Contributor

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

@drewdaemon I know that is quite early but how much work is needed from us after the PR is being created to be merged?

@drewdaemon
Copy link
Contributor

@stratoula exactly... this is very early. I expect it to be easier as we smooth out the rough edges.

In this case, our tests alerted me to a problem with our coalesce definition and with some asciidoc stuff sneaking into the function descriptions.

The Elasticsearch team had closed elastic/elasticsearch#108982, so I assumed we could use their generated coalesce definition instead of our Kibana-side override. I updated the PR, but the tests caught the fact that they had forgotten to add a signature for version (see elastic/elasticsearch#109032 (comment)).

So, I had to make the fix manually on our side.

Both problems (coalesce and asciidoc links) were pre-existing but, since the fix needed to be made in the function definition generator, this felt like a reasonable place to do it. I wouldn't "count" the work toward the usual effort required. Let's give it a few weeks to really get a sense.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 67940a2 into main Jun 5, 2024
17 checks passed
@drewdaemon drewdaemon deleted the esql_generate_function_definitions_1717388128 branch June 5, 2024 16:56
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants