-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] some signatures missing from generated function definitions #108982
Labels
:Analytics/ES|QL
AKA ESQL
>enhancement
ES|QL-ui
Impacts ES|QL UI
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Comments
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This was referenced May 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this issue
May 27, 2024
Adding more unit tests for `coalesce()` function, in particular adding tests for `ip`, `date` and spatial data types. This also generates the right signatures for Kibana. Related to #108982
Pinging @elastic/kibana-esql (ES|QL-ui) |
elasticsearchmachine
pushed a commit
that referenced
this issue
Jun 4, 2024
Adding more unit tests for MV_DEDUPE function, covering geo_point, geo_shape, cartesian_point and cartesian_shape. This also adds docs for Kibana. Fixes #108982
This was referenced Jun 5, 2024
drewdaemon
added a commit
to elastic/kibana
that referenced
this issue
Jun 11, 2024
…185901) With the resolution of elastic/elasticsearch#108982, we can use the Elasticsearch definitions for `mv_dedupe` and `coalesce`! We have also had a couple instances lately of people not noticing the "auto-generated" warning at the top of the function definitions file. I have sprinkled warnings throughout so that it's more clear that any manual changes will be wiped out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
>enhancement
ES|QL-ui
Impacts ES|QL UI
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Description
With elastic/kibana#179584 we are starting to use the definitions from
docs/reference/esql/functions/kibana/definition/
in our client-side validation and autocomplete features. This is an awesome advancement, but a few provided definitions are incomplete.mv_dedupe
is missing signatures forcartesian_point
,cartesian_shape
,geo_shape
,geo_point
ES|QL: add more tests for mv_dedupe (geo and cartesian) #109342coalesce
is missing signatures fordate
,ip
,cartesian_point
,cartesian_shape
,geo_point
,geo_shape
,version
ES|QL: more tests for coalesce() function #109032The text was updated successfully, but these errors were encountered: