Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] some signatures missing from generated function definitions #108982

Closed
2 tasks done
drewdaemon opened this issue May 23, 2024 · 2 comments · Fixed by #109342
Closed
2 tasks done

[ES|QL] some signatures missing from generated function definitions #108982

drewdaemon opened this issue May 23, 2024 · 2 comments · Fixed by #109342
Assignees
Labels
:Analytics/ES|QL AKA ESQL >enhancement ES|QL-ui Impacts ES|QL UI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented May 23, 2024

Description

With elastic/kibana#179584 we are starting to use the definitions from docs/reference/esql/functions/kibana/definition/ in our client-side validation and autocomplete features. This is an awesome advancement, but a few provided definitions are incomplete.

@drewdaemon drewdaemon added >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:triage Requires assignment of a team area label :Analytics/ES|QL AKA ESQL ES|QL-ui Impacts ES|QL UI labels May 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 23, 2024
@luigidellaquila luigidellaquila self-assigned this May 24, 2024
elasticsearchmachine pushed a commit that referenced this issue May 27, 2024
Adding more unit tests for `coalesce()` function, in particular adding
tests for `ip`, `date` and spatial data types.

This also generates the right signatures for Kibana.

Related to #108982
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/kibana-esql (ES|QL-ui)

elasticsearchmachine pushed a commit that referenced this issue Jun 4, 2024
Adding more unit tests for MV_DEDUPE function, covering geo_point,
geo_shape, cartesian_point and cartesian_shape. This also adds docs for
Kibana.

Fixes #108982
drewdaemon added a commit to elastic/kibana that referenced this issue Jun 11, 2024
…185901)

With the resolution of
elastic/elasticsearch#108982, we can use the
Elasticsearch definitions for `mv_dedupe` and `coalesce`!

We have also had a couple instances lately of people not noticing the
"auto-generated" warning at the top of the function definitions file. I
have sprinkled warnings throughout so that it's more clear that any
manual changes will be wiped out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement ES|QL-ui Impacts ES|QL UI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants