Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] - remove tGridEventRenderedViewEnabled feature flag #184479

Merged
merged 1 commit into from
May 30, 2024
Merged

[Security Solution] - remove tGridEventRenderedViewEnabled feature flag #184479

merged 1 commit into from
May 30, 2024

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented May 29, 2024 •
edited
Loading

Summary

The tGridEventRenderedViewEnabled feature flag was last modified on August 2021 (see PR). Since then, the value has been true.

This PR removes the feature flag entirely, as I don't think we should need it, after nearly 3 years of it being enabled.

Checklist

@PhilippeOberti PhilippeOberti force-pushed the remove-tgrideventrendererview-ff branch from 283e91b to 0bccb20 Compare May 29, 2024 21:51
@PhilippeOberti PhilippeOberti force-pushed the remove-tgrideventrendererview-ff branch from 0bccb20 to 415e161 Compare May 29, 2024 23:40
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.2MB 15.2MB -118.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 84.1KB 84.1KB -33.0B

History

  • 💔 Build #212954 failed 0bccb20e34d1e1838bc0306e021f0305df912f2d
  • 💔 Build #212951 failed 283e91b51017b2845f98954a36e6e33bf5669743

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti marked this pull request as ready for review May 30, 2024 03:26
@PhilippeOberti PhilippeOberti requested review from a team as code owners May 30, 2024 03:26
@PhilippeOberti PhilippeOberti added the Team:Threat Hunting:Investigations Security Solution Investigations Team label May 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti added v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels May 30, 2024
@PhilippeOberti PhilippeOberti merged commit de477ed into elastic:main May 30, 2024
41 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 30, 2024
@PhilippeOberti PhilippeOberti deleted the remove-tgrideventrendererview-ff branch May 30, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PhilippeOberti @kibana-ci @elasticmachine @kqualters-elastic @kibanamachine