[SECURITY SOLUTION] [RAC] Event rendered view #108644

XavierM · 2021-08-16T02:23:23Z

Summary

Integrating the Event rendered view in alerts page to have a better way to view the row render

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-08-16T02:23:25Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

x-pack/plugins/timelines/public/components/t_grid/event_rendered_view/selector/index.tsx

mdefazio

Are we able to have a default event renderer? I'm still seeing the reason statement in place of the event summary

I think the text within the dropdown to switch views can be updated (we reference 'Event renderer' in the title and then 'summary' in the description). I know this was a carry-over from an older design mockup
Suggestion: View a rendering of the event flow for each alert @MikePaquette @paulewing Thoughts here?

Change the gutter to medium between the additional filters and grid/event view dropdown

Looks like there's an odd width change happening on hover that is causing the scrollbars to appear/disappear. Not sure if it's related to this PR or not

XavierM · 2021-08-16T13:00:49Z

@mdefazio I thought that the default event render will be the reason that's the way I understand it @paulewing ?

mdefazio

Fixing my comments to be a bit clearer:

The goal for this view was to have a way to brows only the event renders without the extra bits from the data view. So by including the reason statement within this, we're going back on what we hoped to achieve here. It will also be confusing if a user switches to this explicit view and does not seen an event renderer
Suggestion for dropdown text: View a rendering of the event flow for each alert @MikePaquette @paulewing Thoughts here?
Change the gutter to medium between the additional filters and grid/event view dropdown (didn't check if this was already completed)
An odd width change happening on hover that is causing the scrollbars to appear/disappear. Not sure if it's related to this PR or not

…-summary-view

kibanamachine · 2021-08-17T17:12:04Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: f917c86
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup2

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/logstash/pipeline_create·js.logstash pipeline create new cancel button discards the pipeline and redirects to the list

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/83231

[00:00:00]       │
[00:06:21]         └-: logstash
[00:06:21]           └-> "before all" hook in "logstash"
[00:08:39]           └-: pipeline create new
[00:08:39]             └-> "before all" hook for "starts with the default values"
[00:08:39]             └-> "before all" hook for "starts with the default values"
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Loading "mappings.json"
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Loading "data.json.gz"
[00:08:39]               │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_task_manager_8.0.0_001/GyDBdgNTTIKHQ5NewwCARw] deleting index
[00:08:39]               │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_1/xSby8JKyTte_df84x6IrDw] deleting index
[00:08:39]               │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_001/uzoEoR0GQe2X6g9-3eFgHA] deleting index
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Deleted existing index ".kibana_8.0.0_001"
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Deleted existing index ".kibana_1"
[00:08:39]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Created index ".kibana_1"
[00:08:39]               │ debg [x-pack/test/functional/es_archives/logstash/empty] ".kibana_1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:08:39]               │ info [x-pack/test/functional/es_archives/logstash/empty] Indexed 2 docs into ".kibana"
[00:08:39]               │ debg Migrating saved objects
[00:08:39]               │ proc [kibana]   log   [15:24:15.743] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 3ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.746] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 7ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.749] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> CHECK_UNKNOWN_DOCUMENTS. took: 3ms.
[00:08:39]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:08:39]               │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:08:39]               │ proc [kibana]   log   [15:24:15.755] [info][savedobjects-service] [.kibana] CHECK_UNKNOWN_DOCUMENTS -> SET_SOURCE_WRITE_BLOCK. took: 6ms.
[00:08:39]               │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_1/v47dVAxxTpSdfuZsFOBbeA]]
[00:08:39]               │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_1]
[00:08:39]               │ proc [kibana]   log   [15:24:15.844] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 101ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.867] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CALCULATE_EXCLUDE_FILTERS. took: 112ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.870] [info][savedobjects-service] [.kibana] CALCULATE_EXCLUDE_FILTERS -> CREATE_REINDEX_TEMP. took: 3ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.893] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 49ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.893] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 153ms
[00:08:39]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:08:39]               │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:08:39]               │ proc [kibana]   log   [15:24:15.958] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 88ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.962] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 4ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.968] [info][savedobjects-service] [.kibana] Starting to process 2 documents.
[00:08:39]               │ proc [kibana]   log   [15:24:15.969] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_INDEX. took: 6ms.
[00:08:39]               │ proc [kibana]   log   [15:24:15.970] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 2ms.
[00:08:39]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/6miaWxlrRwqmxYJEuSTFPQ] update_mapping [_doc]
[00:08:39]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/6miaWxlrRwqmxYJEuSTFPQ] update_mapping [_doc]
[00:08:39]               │ proc [kibana]   log   [15:24:16.039] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 69ms.
[00:08:39]               │ proc [kibana]   log   [15:24:16.044] [info][savedobjects-service] [.kibana] Processed 2 documents out of 2.
[00:08:39]               │ proc [kibana]   log   [15:24:16.045] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 5ms.
[00:08:39]               │ proc [kibana]   log   [15:24:16.049] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 5ms.
[00:08:40]               │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_8.0.0_reindex_temp/6miaWxlrRwqmxYJEuSTFPQ]]
[00:08:40]               │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:08:40]               │ proc [kibana]   log   [15:24:16.104] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 55ms.
[00:08:40]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:08:40]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:08:40]               │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:08:40]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/WNjusSLDTTirtcNdLKPPYA] create_mapping
[00:08:40]               │ proc [kibana]   log   [15:24:16.227] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 123ms.
[00:08:40]               │ proc [kibana]   log   [15:24:16.230] [info][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 3ms.
[00:08:40]               │ proc [kibana]   log   [15:24:16.232] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 2ms.
[00:08:40]               │ proc [kibana]   log   [15:24:16.237] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 5ms.
[00:08:40]               │ proc [kibana]   log   [15:24:16.239] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 2ms.
[00:08:40]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/WNjusSLDTTirtcNdLKPPYA] update_mapping [_doc]
[00:08:40]               │ proc [kibana]   log   [15:24:16.309] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 70ms.
[00:08:40]               │ info [o.e.t.LoggingTaskListener] [node-01] 18545 finished with response BulkByScrollResponse[took=19.1ms,timed_out=false,sliceId=null,updated=2,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:08:40]               │ proc [kibana]   log   [15:24:16.413] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 104ms.
[00:08:40]               │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_reindex_temp/6miaWxlrRwqmxYJEuSTFPQ] deleting index
[00:08:40]               │ proc [kibana]   log   [15:24:16.455] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 42ms.
[00:08:40]               │ proc [kibana]   log   [15:24:16.456] [info][savedobjects-service] [.kibana] Migration completed after 716ms
[00:08:40]               │ debg [x-pack/test/functional/es_archives/logstash/empty] Migrated Kibana index after loading Kibana data
[00:08:40]               │ debg [x-pack/test/functional/es_archives/logstash/empty] Ensured that default space exists in .kibana
[00:08:40]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true,"visualization:visualize:legacyPieChartsLibrary":true}
[00:08:42]             └-> starts with the default values
[00:08:42]               └-> "before each" hook: global before each for "starts with the default values"
[00:08:42]               │ debg navigating to logstashPipelines url: http://localhost:61211/app/management/ingest/pipelines
[00:08:42]               │ debg navigate to: http://localhost:61211/app/management/ingest/pipelines
[00:08:42]               │ debg browser[INFO] http://localhost:61211/app/management/ingest/pipelines?_t=1629213858167 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:08:42]               │
[00:08:42]               │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:08:42]               │ debg ... sleep(700) start
[00:08:42]               │ debg ... sleep(700) end
[00:08:42]               │ debg returned from get, calling refresh
[00:08:43]               │ debg browser[INFO] http://localhost:61211/app/management/ingest/pipelines?_t=1629213858167 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:08:43]               │
[00:08:43]               │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:08:44]               │ debg currentUrl = http://localhost:61211/app/management/ingest/pipelines
[00:08:44]               │          appUrl = http://localhost:61211/app/management/ingest/pipelines
[00:08:44]               │ debg TestSubjects.find(kibanaChrome)
[00:08:44]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:08:44]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/WNjusSLDTTirtcNdLKPPYA] update_mapping [_doc]
[00:08:44]               │ debg ... sleep(501) start
[00:08:45]               │ debg ... sleep(501) end
[00:08:45]               │ debg in navigateTo url = http://localhost:61211/app/management/ingest/pipelines
[00:08:45]               │ debg Waiting up to 20000ms for pipline list visible on screen...
[00:08:45]               │ debg TestSubjects.find(pipelineList)
[00:08:45]               │ debg Find.findByCssSelector('[data-test-subj="pipelineList"]') with timeout=10000
[00:08:45]               │ debg TestSubjects.exists(loadingPipelines)
[00:08:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loadingPipelines"]') with timeout=2500
[00:08:47]               │ debg --- retry.tryForTime error: [data-test-subj="loadingPipelines"] is not displayed
[00:08:48]               │ debg TestSubjects.click(pipelineList > btnAdd)
[00:08:48]               │ debg Find.clickByCssSelector('[data-test-subj="pipelineList"] [data-test-subj="btnAdd"]') with timeout=10000
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj="pipelineList"] [data-test-subj="btnAdd"]') with timeout=10000
[00:08:48]               │ debg Waiting up to 20000ms for pipeline editor visible...
[00:08:48]               │ debg TestSubjects.exists(~pipelineEdit)
[00:08:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="pipelineEdit"]') with timeout=2500
[00:08:48]               │ debg browser[WARNING] http://localhost:61211/45401/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.@elastic.js 114:226004 "[EUI] - DEPRECATION: `EuiCodeEditor` is deprecated and will be removed in a future release.
[00:08:48]               │      See https://ela.st/euicodeeditor for migration options."
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > inputId, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > inputId)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="inputId"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > inputDescription, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > inputDescription)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="inputDescription"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > acePipeline)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="acePipeline"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > inputWorkers, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > inputWorkers)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="inputWorkers"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > inputBatchSize, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > inputBatchSize)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="inputBatchSize"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > selectQueueType, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > selectQueueType)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="selectQueueType"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > inputQueueMaxBytesNumber, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > inputQueueMaxBytesNumber)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="inputQueueMaxBytesNumber"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > selectQueueMaxBytesUnits, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > selectQueueMaxBytesUnits)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="selectQueueMaxBytesUnits"]') with timeout=10000
[00:08:48]               │ debg TestSubjects.getAttribute(~pipelineEdit > inputQueueCheckpointWrites, value, tryTimeout=120000, findTimeout=10000)
[00:08:48]               │ debg TestSubjects.find(~pipelineEdit > inputQueueCheckpointWrites)
[00:08:48]               │ debg Find.findByCssSelector('[data-test-subj~="pipelineEdit"] [data-test-subj="inputQueueCheckpointWrites"]') with timeout=10000
[00:08:48]               └- ✓ pass  (6.6s) "logstash pipeline create new starts with the default values"
[00:08:48]             └-: save button
[00:08:48]               └-> "before all" hook for "creates the pipeline and redirects to the list"
[00:09:04]             └-: cancel button
[00:09:04]               └-> "before all" hook for "discards the pipeline and redirects to the list"
[00:09:04]               └-> discards the pipeline and redirects to the list
[00:09:04]                 └-> "before each" hook: global before each for "discards the pipeline and redirects to the list"
[00:09:04]                 │ debg navigating to logstashPipelines url: http://localhost:61211/app/management/ingest/pipelines
[00:09:04]                 │ debg navigate to: http://localhost:61211/app/management/ingest/pipelines
[00:09:04]                 │ debg browser[INFO] http://localhost:61211/app/management/ingest/pipelines?_t=1629213880420 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:04]                 │
[00:09:04]                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:04]                 │ debg ... sleep(700) start
[00:09:05]                 │ debg ... sleep(700) end
[00:09:05]                 │ debg returned from get, calling refresh
[00:09:06]                 │ERROR browser[SEVERE] http://localhost:61211/45401/bundles/core/core.entry.js 12:156436 TypeError: Failed to fetch
[00:09:06]                 │          at fetch_Fetch.fetchResponse (http://localhost:61211/45401/bundles/core/core.entry.js:6:27229)
[00:09:06]                 │          at async http://localhost:61211/45401/bundles/core/core.entry.js:6:25046
[00:09:06]                 │          at async http://localhost:61211/45401/bundles/core/core.entry.js:6:24952
[00:09:06]                 │ debg browser[INFO] http://localhost:61211/app/management/ingest/pipelines?_t=1629213880420 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:06]                 │
[00:09:06]                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:06]                 │ debg currentUrl = http://localhost:61211/app/management/ingest/pipelines
[00:09:06]                 │          appUrl = http://localhost:61211/app/management/ingest/pipelines
[00:09:06]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:06]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:07]                 │ debg ... sleep(501) start
[00:09:07]                 │ debg ... sleep(501) end
[00:09:07]                 │ debg in navigateTo url = http://localhost:61211/app/management/ingest/pipelines
[00:09:07]                 │ debg Waiting up to 20000ms for pipline list visible on screen...
[00:09:07]                 │ debg TestSubjects.find(pipelineList)
[00:09:07]                 │ debg Find.findByCssSelector('[data-test-subj="pipelineList"]') with timeout=10000
[00:09:07]                 │ debg TestSubjects.exists(loadingPipelines)
[00:09:07]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loadingPipelines"]') with timeout=2500
[00:09:10]                 │ debg --- retry.tryForTime error: [data-test-subj="loadingPipelines"] is not displayed
[00:09:10]                 │ debg Waiting up to 20000ms for pipline list visible on screen...
[00:09:10]                 │ debg TestSubjects.find(pipelineList)
[00:09:10]                 │ debg Find.findByCssSelector('[data-test-subj="pipelineList"]') with timeout=10000
[00:09:10]                 │ debg TestSubjects.exists(loadingPipelines)
[00:09:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loadingPipelines"]') with timeout=2500
[00:09:13]                 │ debg --- retry.tryForTime error: [data-test-subj="loadingPipelines"] is not displayed
[00:09:13]                 │ debg TestSubjects.find(pipelineTable)
[00:09:13]                 │ debg Find.findByCssSelector('[data-test-subj="pipelineTable"]') with timeout=10000
[00:09:14]                 │ debg navigating to logstashPipelines url: http://localhost:61211/app/management/ingest/pipelines
[00:09:14]                 │ debg navigate to: http://localhost:61211/app/management/ingest/pipelines
[00:09:14]                 │ debg browser[INFO] http://localhost:61211/app/management/ingest/pipelines?_t=1629213890061 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:14]                 │
[00:09:14]                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:14]                 │ debg ... sleep(700) start
[00:09:14]                 │ debg ... sleep(700) end
[00:09:14]                 │ debg returned from get, calling refresh
[00:09:15]                 │ debg browser[INFO] http://localhost:61211/app/management/ingest/pipelines?_t=1629213890061 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:15]                 │
[00:09:15]                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:16]                 │ debg currentUrl = http://localhost:61211/app/management/ingest/pipelines
[00:09:16]                 │          appUrl = http://localhost:61211/app/management/ingest/pipelines
[00:09:16]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:16]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:16]                 │ERROR browser[SEVERE] http://localhost:61211/api/licensing/info - Failed to load resource: net::ERR_NETWORK_CHANGED
[00:09:16]                 │ERROR browser[SEVERE] http://localhost:61211/internal/global_search/searchable_types - Failed to load resource: net::ERR_NETWORK_CHANGED
[00:09:16]                 │ debg browser[INFO] http://localhost:61211/45401/bundles/core/core.entry.js 12:157356 "Detected an unhandled Promise rejection.
[00:09:16]                 │      TypeError: Failed to fetch"
[00:09:16]                 │ERROR browser[SEVERE] http://localhost:61211/45401/bundles/core/core.entry.js 5:2474 
[00:09:16]                 │ debg ... sleep(501) start
[00:09:17]                 │ debg ... sleep(501) end
[00:09:17]                 │ debg in navigateTo url = http://localhost:61211/app/management/ingest/pipelines
[00:09:17]                 │ debg Waiting up to 20000ms for pipline list visible on screen...
[00:09:17]                 │ debg TestSubjects.find(pipelineList)
[00:09:17]                 │ debg Find.findByCssSelector('[data-test-subj="pipelineList"]') with timeout=10000
[00:09:27]                 │ debg --- retry.waitFor error: Waiting for element to be located By(css selector, [data-test-subj="pipelineList"])
[00:09:27]                 │      Wait timed out after 10017ms
[00:09:27]                 │ debg TestSubjects.find(pipelineList)
[00:09:27]                 │ debg Find.findByCssSelector('[data-test-subj="pipelineList"]') with timeout=10000
[00:09:37]                 │ debg --- retry.waitFor error: Waiting for element to be located By(css selector, [data-test-subj="pipelineList"])
[00:09:37]                 │      Wait timed out after 10035ms
[00:09:38]                 │ info Taking screenshot "/dev/shm/workspace/parallel/21/kibana/x-pack/test/functional/screenshots/failure/logstash pipeline create new cancel button discards the pipeline and redirects to the list.png"
[00:09:38]                 │ info Current URL is: http://localhost:61211/app/management/ingest/pipelines
[00:09:38]                 │ info Saving page source to: /dev/shm/workspace/parallel/21/kibana/x-pack/test/functional/failure_debug/html/logstash pipeline create new cancel button discards the pipeline and redirects to the list.html
[00:09:38]                 └- ✖ fail: logstash pipeline create new cancel button discards the pipeline and redirects to the list
[00:09:38]                 │      Error: timed out waiting for pipline list visible on screen -- last error: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="pipelineList"])
[00:09:38]                 │ Wait timed out after 10035ms
[00:09:38]                 │     at /dev/shm/workspace/parallel/21/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:09:38]                 │     at runMicrotasks (<anonymous>)
[00:09:38]                 │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:09:38]                 │       at onFailure (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
[00:09:38]                 │       at retryForSuccess (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:09:38]                 │       at retryForTruthy (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
[00:09:38]                 │       at RetryService.waitFor (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry.ts:59:5)
[00:09:38]                 │       at PipelineList.assertExists (test/functional/services/pipeline_list.js:167:7)
[00:09:38]                 │       at LogstashPageObject.gotoPipelineList (test/functional/page_objects/logstash_page.ts:17:5)
[00:09:38]                 │       at LogstashPageObject.gotoNewPipelineEditor (test/functional/page_objects/logstash_page.ts:21:5)
[00:09:38]                 │       at Context.<anonymous> (test/functional/apps/logstash/pipeline_create.js:95:9)
[00:09:38]                 │       at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:09:38]                 │ 
[00:09:38]                 │

Stack Trace

Error: timed out waiting for pipline list visible on screen -- last error: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="pipelineList"])
Wait timed out after 10035ms
    at /dev/shm/workspace/parallel/21/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at onFailure (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
    at retryForSuccess (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at retryForTruthy (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
    at RetryService.waitFor (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry.ts:59:5)
    at PipelineList.assertExists (test/functional/services/pipeline_list.js:167:7)
    at LogstashPageObject.gotoPipelineList (test/functional/page_objects/logstash_page.ts:17:5)
    at LogstashPageObject.gotoNewPipelineEditor (test/functional/page_objects/logstash_page.ts:21:5)
    at Context.<anonymous> (test/functional/apps/logstash/pipeline_create.js:95:9)
    at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`timelines`	313	312	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.5MB	6.5MB	+51.0B
`timelines`	421.2KB	426.8KB	+5.5KB
total			+5.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	211.8KB	211.8KB	+33.0B
`timelines`	313.0KB	313.1KB	+66.0B
total			+99.0B

History

💔 Build #146173 failed 8026993
💚 Build #146104 succeeded ffea64f
💚 Build #146085 succeeded 6f9f06a
💔 Build #145805 failed 6970f3a
💔 Build #145790 failed 8bee34f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mdefazio

✅ Strange hover + scrollbar addition bug seems to be fixed

Seeing a few other points of concern: Not sure if the last few are related to this PR.

1/ Looks like our select all checkbox is in the same thead cell as the actions. Also then causing the action icons to ben too close the the row checkbox

2/ We should define widths for the first few columns so there's not so much space between the actions, timestamp and rule
(~140px for actions, but likely needs to be less since this includes the checkbox column)
(200px for Timestamp)

3/ Seeing a few rule rows that do not have default reason statements on them

4/ I'm seeing horizontal scrolling by just a little bit. Shouldn't this be possible to avoid? with this view (assuming the row renderers can break lines according to their container)

5/ I'm seeing a few options in the renderer that still have dragging available

mdefazio · 2021-08-17T20:08:08Z

Since this feature will be behind a feature flag and require additional testing, I'll mark as approved. The following issues have been created based on the last comment and should be necessary for feature flag to be removed:

#108990
#108988
#108987
#108984

mdefazio

See list of issues based on review. Approving based on feature flag decision.

michaelolo24 · 2021-08-17T20:45:49Z

x-pack/plugins/timelines/public/components/t_grid/event_rendered_view/selector/index.tsx

+    >
+      <ContainerEuiSelectable>
+        <EuiSelectable
+          aria-label="Basic example"


nit: may want to change this from the eui example

michaelolo24 · 2021-08-17T20:46:19Z

x-pack/plugins/timelines/public/components/t_grid/event_rendered_view/selector/index.tsx

+    () => [
+      {
+        label: gridView,
+        key: 'gridView',


nit: we can toss gridView and eventRenderedView in constants

michaelolo24

LGTM! 💪🏾

kibanamachine · 2021-08-18T00:20:34Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* wip * match design for selecting grid view * wip to integrate event rendered view * wip * integration of the event rendered * fix perPage action on Euibasic table * Add bulding block background color to EventRenderedView * styling * remove header * fix types * fix unit tests * use memo for listProps * fix styling + add feature flag * review I * fix merge * change the gutter size Co-authored-by: Pablo Neves Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

* wip * match design for selecting grid view * wip to integrate event rendered view * wip * integration of the event rendered * fix perPage action on Euibasic table * Add bulding block background color to EventRenderedView * styling * remove header * fix types * fix unit tests * use memo for listProps * fix styling + add feature flag * review I * fix merge * change the gutter size Co-authored-by: Pablo Neves Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Pablo Neves Machado <pablo.nevesmachado@elastic.co> Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

XavierM added 8 commits July 30, 2021 14:10

wip

25adac9

match design for selecting grid view

2a8ff53

Merge branch 'master' of github.com:elastic/kibana into rac-summary-view

ca6dad4

wip to integrate event rendered view

4a937f9

Merge branch 'master' of github.com:elastic/kibana into rac-summary-view

f98851b

wip

795afb3

Merge branch 'master' of github.com:elastic/kibana into rac-summary-view

b19f7c6

integration of the event rendered

d937968

XavierM added release_note:enhancement v8.0.0 Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0 labels Aug 16, 2021

XavierM requested review from machadoum, mdefazio, andrew-goldstein and semd August 16, 2021 02:23

XavierM requested review from a team as code owners August 16, 2021 02:23

XavierM commented Aug 16, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/event_rendered_view/selector/index.tsx Outdated Show resolved Hide resolved

mdefazio reviewed Aug 16, 2021

View reviewed changes

XavierM and others added 5 commits August 16, 2021 10:14

fix perPage action on Euibasic table

42e0c89

Merge branch 'master' of github.com:elastic/kibana into rac-summary-view

c639690

Add bulding block background color to EventRenderedView

e29d182

Merge branch 'master' of github.com:elastic/kibana into rac-summary-view

8bee34f

styling

6970f3a

mdefazio requested changes Aug 16, 2021

View reviewed changes

remove header

7a8d5bc

angorayc and others added 9 commits August 17, 2021 10:57

fix types

c4aa225

Merge branch 'master' of github.com:elastic/kibana into rac-summary-view

8b8351a

fix unit tests

6f9f06a

use memo for listProps

ffea64f

fix styling + add feature flag

6731ab6

review I

cdc2034

Merge branch 'rac-summary-view' of github.com:XavierM/kibana into rac…

05930fe

…-summary-view

fix merge

8026993

change the gutter size

f917c86

XavierM enabled auto-merge (squash) August 17, 2021 18:17

mdefazio requested changes Aug 17, 2021

View reviewed changes

mdefazio approved these changes Aug 17, 2021

View reviewed changes

michaelolo24 reviewed Aug 17, 2021

View reviewed changes

michaelolo24 approved these changes Aug 17, 2021

View reviewed changes

XavierM merged commit 3013e10 into elastic:master Aug 17, 2021

XavierM added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 18, 2021

kibanamachine mentioned this pull request Aug 18, 2021

[7.x] [SECURITY SOLUTION] [RAC] Event rendered view (#108644) #109025

Merged

PhilippeOberti mentioned this pull request May 29, 2024

[Security Solution] - remove tGridEventRenderedViewEnabled feature flag #184479

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SECURITY SOLUTION] [RAC] Event rendered view #108644

[SECURITY SOLUTION] [RAC] Event rendered view #108644

XavierM commented Aug 16, 2021

elasticmachine commented Aug 16, 2021

mdefazio left a comment

XavierM commented Aug 16, 2021

mdefazio left a comment

kibanamachine commented Aug 17, 2021

Standard Out

Stack Trace

mdefazio left a comment

mdefazio commented Aug 17, 2021

mdefazio left a comment

michaelolo24 Aug 17, 2021

michaelolo24 Aug 17, 2021

michaelolo24 left a comment

kibanamachine commented Aug 18, 2021

[SECURITY SOLUTION] [RAC] Event rendered view #108644

[SECURITY SOLUTION] [RAC] Event rendered view #108644

Conversation

XavierM commented Aug 16, 2021

Summary

Checklist

elasticmachine commented Aug 16, 2021

mdefazio left a comment

Choose a reason for hiding this comment

XavierM commented Aug 16, 2021

mdefazio left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 17, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

mdefazio left a comment

Choose a reason for hiding this comment

mdefazio commented Aug 17, 2021

mdefazio left a comment

Choose a reason for hiding this comment

michaelolo24 Aug 17, 2021

Choose a reason for hiding this comment

michaelolo24 Aug 17, 2021

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 18, 2021

💚 Backport successful