Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] [Dashboard Navigation] Fix edit filter when navigating from dashboard #166500

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Sep 14, 2023

Summary

This is part of a Quick Wins ticket

This PR fixes this issue, by adding the dataViewId to the createFilter method called by the useNavigation hook according to the respective findings page (Misconfigurations, Vulnerabilities).

It falls back to the security-solution-default data view if a data view can not be found (in case it's manually deleted by the user for example).

Recording

Screen.Recording.2023-09-14.at.12.12.03.PM.mov

@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.11.0 labels Sep 14, 2023
@opauloh opauloh requested a review from a team as a code owner September 14, 2023 19:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 263.9KB 264.1KB +140.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 13.9KB 13.9KB +64.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opauloh opauloh merged commit f9c35e4 into elastic:main Sep 25, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 25, 2023
@opauloh opauloh deleted the quick-wins/fix-edit-filter branch September 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.11.0
Projects
None yet
5 participants