Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Unskip _context_menu tests #164210

Merged
merged 3 commits into from
Aug 23, 2023
Merged

[Console] Unskip _context_menu tests #164210

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ad8250
unskip tests for debugging
alisonelizabeth Aug 17, 2023
dfb20d9
minor improvements to the tests
alisonelizabeth Aug 17, 2023
a69ec0c
Merge branch 'main' into console/flaky_tests_155029
kibanamachine Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/functional/apps/console/_context_menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const browser = getService('browser');
const toasts = getService('toasts');

// FLAKY: https://github.com/elastic/kibana/issues/155029
describe.skip('console context menu', function testContextMenu() {
describe('console context menu', function testContextMenu() {
before(async () => {
await PageObjects.common.navigateToApp('console');
// Ensure that the text area can be interacted with
await PageObjects.console.closeHelpIfExists();
await PageObjects.console.clearTextArea();
await PageObjects.console.enterRequest();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for all of the tests, so I think it makes more sense in the before() hook, rather than in the first test case.

});

it('should open context menu', async () => {
expect(await PageObjects.console.isContextMenuOpen()).to.be(false);
await PageObjects.console.enterRequest();
await PageObjects.console.clickContextMenu();
expect(PageObjects.console.isContextMenuOpen()).to.be.eql(true);
});
Expand Down Expand Up @@ -80,7 +79,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await browser.switchTab(0);
});

it('should auto indent when auto indent button is clicked', async () => {
it('should toggle auto indent when auto indent button is clicked', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way these tests were previously written, the "condense" test was dependent on the previous test running first. I changed this to be a single test and renamed the description.

await PageObjects.console.clearTextArea();
await PageObjects.console.enterRequest('GET _search\n{"query": {"match_all": {}}}');
await PageObjects.console.clickContextMenu();
Expand All @@ -90,10 +89,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const request = await PageObjects.console.getRequest();
expect(request).to.be.eql('GET _search\n{\n "query": {\n "match_all": {}\n }\n}');
});
});

it('should condense when auto indent button is clicked again', async () => {
await PageObjects.console.clickContextMenu();
// Click the auto-indent button again to condense request
await PageObjects.console.clickAutoIndentButton();
// Retry until the request is condensed
await retry.try(async () => {
Expand Down