[Console] Unskip _context_menu tests #164210
Conversation
|
Tests run a total of 400x via flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2915 |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
| before(async () => { | ||
| await PageObjects.common.navigateToApp('console'); | ||
| // Ensure that the text area can be interacted with | ||
| await PageObjects.console.closeHelpIfExists(); | ||
| await PageObjects.console.clearTextArea(); | ||
| await PageObjects.console.enterRequest(); |
There was a problem hiding this comment.
This is needed for all of the tests, so I think it makes more sense in the before() hook, rather than in the first test case.
| @@ -80,7 +79,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| await browser.switchTab(0); | |||
| }); | |||
|
|
|||
| it('should auto indent when auto indent button is clicked', async () => { | |||
| it('should toggle auto indent when auto indent button is clicked', async () => { | |||
There was a problem hiding this comment.
The way these tests were previously written, the "condense" test was dependent on the previous test running first. I changed this to be a single test and renamed the description.
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Thanks for unskipping and improving the tests @alisonelizabeth! LGTM
This PR unskips the Console
_context_menufunctional tests and makes a few minor improvements to the tests themselves.Fixes #155029
Fixes #143230