Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky #118272] Unskip tests #163319

Merged
merged 2 commits into from
Aug 11, 2023
Merged

[Flaky #118272] Unskip tests #163319

merged 2 commits into from
Aug 11, 2023

Conversation

afharo
Copy link
Member

@afharo afharo commented Aug 7, 2023 •
edited by kibanamachine
Loading

Summary

Resolves #118272

As suggested in the issue' comments. A previous PR should have fixed this flakiness.

✅ Flaky test runner (400x): https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2824

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Aug 7, 2023
@afharo afharo force-pushed the flaky-116048-som-access-control branch from 6e4662c to 920932d Compare August 9, 2023 08:02
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #17 / ObservabilityApp Observability Rules page Rules table shows the rules table

Metrics [docs]

✅ unchanged

History

  • 💔 Build #148425 failed 6e4662c170a40d9fbe64bf90f13b309f3ce9f242
  • 💔 Build #148021 failed 10deea021548a204d7b6bfd18f61223c6c2356fe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo commented Aug 9, 2023
View reviewed changes
...nctional/apps/saved_objects_management/feature_controls/saved_objects_management_security.ts
version = await kibanaServer.version.get();
// version = await kibanaServer.version.get();
// Using the version below instead because we don't need the extra `-SNAPSHOT` bit
version = (await kibanaServer.status.get()).version.number;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, we no-longer call the UI settings with the -SNAPSHOT bit.

@afharo afharo marked this pull request as ready for review August 10, 2023 09:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo requested a review from a team August 10, 2023 09:45
@gsoldevila
Copy link
Contributor

The PR does not currently unskip #116048.

@afharo afharo changed the title [Flaky #116048 #118272] Unskip tests [Flaky #118272] Unskip tests Aug 11, 2023
@afharo
Copy link
Member Author

afharo commented Aug 11, 2023

The PR does not currently unskip #116048.

Right! My bad! I'll raise a separate PR for that

gsoldevila
gsoldevila approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@afharo afharo merged commit 5de69cb into elastic:main Aug 11, 2023
@afharo afharo deleted the flaky-116048-som-access-control branch August 11, 2023 08:32
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2023
@afharo
[Flaky elastic#118272] Unskip tests (elastic#163319)
e922212 
(cherry picked from commit 5de69cb)
This was referenced Aug 11, 2023
Closed
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2023
@afharo
[Flaky elastic#118272] Unskip tests (elastic#163319)
63e0b76 
(cherry picked from commit 5de69cb)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 11, 2023
@kibanamachine @afharo
[8.9] [Flaky #118272] Unskip tests (#163319) (#163680)
fd28e11 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Flaky #118272] Unskip tests
(#163319)](#163319)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-08-11T08:32:32Z","message":"[Flaky
#118272] Unskip tests
(#163319)","sha":"5de69cb567e8f6fde93f09b839710e1ee8a3cc72","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical
debt","release_note:skip","backport:all-open","v8.10.0"],"number":163319,"url":"https://github.com/elastic/kibana/pull/163319","mergeCommit":{"message":"[Flaky
#118272] Unskip tests
(#163319)","sha":"5de69cb567e8f6fde93f09b839710e1ee8a3cc72"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163319","number":163319,"mergeCommit":{"message":"[Flaky
#118272] Unskip tests
(#163319)","sha":"5de69cb567e8f6fde93f09b839710e1ee8a3cc72"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2023
@jloleysens
Merge branch 'main' into send-build-number-in-header
832af82 
* main: (64 commits)
  [ML] Transforms: Fix privileges check. (elastic#163687)
  [Log Explorer] Add test suite for Dataset Selector (elastic#163079)
  [Security Solution][Endpoint] Add API checks to Endpoint Policy create/update for checking `endpointPolicyProtections` is enabled (elastic#163429)
  [Security Solution] Fix flaky test: x-pack/test/detection_engine_api_integration/security_and_spaces/update_prebuilt_rules_package/update_prebuilt_rules_package·ts - update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package (elastic#163241)
  [Security Solution] expandable flyout - replace feature flag with advanced settings toggle (elastic#161614)
  [DOCS] Adds the release notes for the 8.9.1 release. (elastic#163578)
  [FTR] Implement browser network condition utils (elastic#163633)
  [Security Solution] Unskip rules table auto-refresh Cypress tests (elastic#163451)
  [Security Solution] Re-enable fixed rule snoozing Cypress test (elastic#160037)
  [Flaky Test elastic#111821] Mock `moment` to avoid midnight TZ issues (elastic#163157)
  Document interactive setup (elastic#163619)
  [Lens] Align decoration color with text color for layer actions (elastic#163630)
  [Lens] Relax counter field checks for saved visualizations with unsupported operations (elastic#163515)
  [Security Solution][Endpoint] Removes pMap and uses a for loop instead (elastic#163509)
  [Enterprise Search] Update Workplace Search connectors doclink (elastic#163676)
  Update APM (main) (elastic#163623)
  [Serverless] Partially fix lens/maps/visualize breadcrumbs missing title  (elastic#163476)
  [Flaky elastic#118272] Unskip tests (elastic#163319)
  [APM] Make service group saved objects exportable (elastic#163569)
  [Observability AI Assistant] Action menu item (elastic#163463)
  ...
@mistic
Copy link
Member

mistic commented Aug 17, 2023

This pr didn't make it into the build candidate for v8.9.1. Updating the labels.

@mistic mistic removed the v8.9.1 label Aug 17, 2023
@mistic mistic added the v8.9.2 label Aug 17, 2023
@afharo afharo added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport:all-open Backport to all branches that could still receive a release labels Aug 23, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.10 Cherrypick failed because the selected commit (5de69cb) is empty. Did you already backport this commit?
❌ 8.9 Cherrypick failed because the selected commit (5de69cb) is empty. It looks like the commit was already backported in #163680

Manual backport

To create the backport manually run:

node scripts/backport --pr 163319

Questions ?

Please refer to the Backport tool documentation

@afharo
Copy link
Member Author

afharo commented Aug 23, 2023

yeah... no worries... I just updated the labels, but this was already backported.

This was referenced Aug 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoldevila gsoldevila gsoldevila approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.9.2 v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
6 participants
@afharo @kibana-ci @elasticmachine @gsoldevila @kibanamachine @mistic