Skip to content

Commit

Permalink
[8.9] [Flaky #118272] Unskip tests (#163319) (#163680)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Flaky #118272] Unskip tests
(#163319)](#163319)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-08-11T08:32:32Z","message":"[Flaky
#118272] Unskip tests
(#163319)","sha":"5de69cb567e8f6fde93f09b839710e1ee8a3cc72","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical
debt","release_note:skip","backport:all-open","v8.10.0"],"number":163319,"url":"https://github.com/elastic/kibana/pull/163319","mergeCommit":{"message":"[Flaky
#118272] Unskip tests
(#163319)","sha":"5de69cb567e8f6fde93f09b839710e1ee8a3cc72"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163319","number":163319,"mergeCommit":{"message":"[Flaky
#118272] Unskip tests
(#163319)","sha":"5de69cb567e8f6fde93f09b839710e1ee8a3cc72"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
  • Loading branch information
kibanamachine and afharo authored Aug 11, 2023
1 parent 0d8ff48 commit fd28e11
Showing 1 changed file with 27 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
let version: string = '';
const find = getService('find');

// FLAKY: https://github.com/elastic/kibana/issues/118272
describe.skip('feature controls saved objects management', () => {
describe('feature controls saved objects management', () => {
before(async () => {
version = await kibanaServer.version.get();
// version = await kibanaServer.version.get();
// Using the version below instead because we don't need the extra `-SNAPSHOT` bit
version = (await kibanaServer.status.get()).version.number;
await kibanaServer.importExport.load(
'x-pack/test/functional/fixtures/kbn_archiver/saved_objects_management/feature_controls/security'
);
Expand Down Expand Up @@ -76,31 +77,36 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows all saved objects', async () => {
const objects = await PageObjects.savedObjects.getRowTitles();
expect(objects).to.eql([
`Advanced Settings [${version}]`,
'A Dashboard',
'logstash-*',
'A Pie',
'A Dashboard',
`Global Settings [${version}]`,
`Advanced Settings [${version}]`,
]);
});

it('can view all saved objects in applications', async () => {
const bools = await PageObjects.savedObjects.getTableSummary();
expect(bools).to.eql([
{
title: `Advanced Settings [${version}]`,
canViewInApp: false,
title: 'logstash-*',
canViewInApp: true,
},
{
title: 'A Dashboard',
title: 'A Pie',
canViewInApp: true,
},
{
title: 'logstash-*',
title: 'A Dashboard',
canViewInApp: true,
},
{
title: 'A Pie',
canViewInApp: true,
title: `Global Settings [${version}]`,
canViewInApp: false,
},
{
title: `Advanced Settings [${version}]`,
canViewInApp: false,
},
]);
});
Expand Down Expand Up @@ -195,30 +201,35 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows all saved objects', async () => {
const objects = await PageObjects.savedObjects.getRowTitles();
expect(objects).to.eql([
`Advanced Settings [${version}]`,
'A Dashboard',
'logstash-*',
'A Pie',
'A Dashboard',
`Global Settings [${version}]`,
`Advanced Settings [${version}]`,
]);
});

it('cannot view any saved objects in applications', async () => {
const bools = await PageObjects.savedObjects.getTableSummary();
expect(bools).to.eql([
{
title: `Advanced Settings [${version}]`,
title: 'logstash-*',
canViewInApp: false,
},
{
title: 'A Pie',
canViewInApp: false,
},
{
title: 'A Dashboard',
canViewInApp: false,
},
{
title: 'logstash-*',
title: `Global Settings [${version}]`,
canViewInApp: false,
},
{
title: 'A Pie',
title: `Advanced Settings [${version}]`,
canViewInApp: false,
},
]);
Expand Down

0 comments on commit fd28e11

Please sign in to comment.