[Cases] Fix case view participants tests #162612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
commented
Jul 27, 2023
| @@ -971,6 +971,81 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { | |||
| expect(lastBreadcrumb).to.be(theCase.title); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('reporter', () => { | |||
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
|
@elasticmachine merge upstream |
adcoelho
reviewed
Jul 28, 2023
| }); | ||
|
|
||
| after(async () => { | ||
| await cases.api.deleteAllCases(); |
There was a problem hiding this comment.
nit: since we do it too in afterEach, this one is redundant no?
adcoelho
reviewed
Jul 28, 2023
| const elasticUserText = await participants[1].getVisibleText(); | ||
| const testUserText = await participants[2].getVisibleText(); | ||
|
|
||
| expect(casesAllUserText).to.be('cases all_user'); |
There was a problem hiding this comment.
Which of them is the assignee?
There was a problem hiding this comment.
The casesAllUserText. I will put a comment.
adcoelho
approved these changes
Jul 28, 2023
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @cnasikas |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
## Summary I removed the participants' tests from `x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx` There were a few things being tested: | Old Test | Where is it covered | | ------------- | ------------- | | should render the participants correctly | Moved to an e2e test | | should render Unknown users correctly | Moved to `UserList` | | should render assignees in the participants section | Moved to an e2e test | I also added a small test for reporters. Fixes elastic#152204 Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2734 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I removed the participants' tests from
x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsxThere were a few things being tested:
UserListI also added a small test for reporters.
Fixes #152204
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2734
Checklist
Delete any items that are not applicable to this PR.
For maintainers