Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view/components - Case View Page activity tab Case users Participants should render Unknown users correctly #152204

Closed
kibanamachine opened this issue Feb 27, 2023 · 6 comments · Fixed by #162612
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view/components - Case View Page activity tab Case users Participants should render Unknown users correctly #152204

kibanamachine opened this issue Feb 27, 2023 · 6 comments · Fixed by #162612
Assignees
@cnasikas
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 27, 2023 •
edited
Loading

A test failed on a tracked branch

TestingLibraryElementError: Unable to find an element by: [data-test-subj="case-view-user-list-participants"]

Ignored nodes: comments, script, style
<body>
  <div />
</body>
    at Object.getElementError (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/config.js:40:19)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:90:38
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:62:17
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:111:19
    at Object.getByTestId (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx:373:51)
    at Promise.then.completed (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:289:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:222:10)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:248:40)
    at runNextTicks (node:internal/process/task_queues:61:5)
    at processTimers (node:internal/timers:499:9)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:184:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:86:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:26:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:120:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-b7b192556125262f/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 27, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 27, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Feb 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas mentioned this issue Jun 29, 2023
Merged
2 tasks
cnasikas added a commit that referenced this issue Jun 29, 2023
@cnasikas @kibanamachine
[Cases] Test case_view_activity.test.tsx suite (#160639)
6349724 
## Summary

Fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

Successful runs:

-
a7a19c1
(40 times)
-
f5e0645
(45 times)
-
d9838cc
(40 times)

Fixes: #151981,
#151979,
#151980,
#152209,
#152207,
#152208,
#152203,
#152203,
#152201,
#152206,
#152202,
#152204,
#152200

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 29, 2023
@cnasikas
[Cases] Test case_view_activity.test.tsx suite (elastic#160639)
6f69f62 
## Summary

Fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

Successful runs:

-
elastic@a7a19c1
(40 times)
-
elastic@f5e0645
(45 times)
-
elastic@d9838cc
(40 times)

Fixes: elastic#151981,
elastic#151979,
elastic#151980,
elastic#152209,
elastic#152207,
elastic#152208,
elastic#152203,
elastic#152203,
elastic#152201,
elastic#152206,
elastic#152202,
elastic#152204,
elastic#152200

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6349724)
@cnasikas
Copy link
Member

Fixed by #160639

@kibanamachine kibanamachine reopened this Jul 17, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jul 18, 2023
@mistic
skip flaky suite (#152204)
fae89ff
@mistic
Copy link
Member

mistic commented Jul 18, 2023

Skipped.

main: fae89ff

@cnasikas cnasikas self-assigned this Jul 25, 2023
@cnasikas cnasikas mentioned this issue Jul 27, 2023
Merged
2 tasks
cnasikas added a commit that referenced this issue Jul 28, 2023
@cnasikas @kibanamachine
[Cases] Fix case view participants tests (#162612)
08db8ee 
## Summary

I removed the participants' tests from
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

There were a few things being tested:

| Old Test  | Where is it covered |
| ------------- | ------------- |
| should render the participants correctly  | Moved to an e2e test |
| should render Unknown users correctly  | Moved to  `UserList` |
| should render assignees in the participants section | Moved to an e2e
test |

I also added a small test for reporters.

Fixes #152204
Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2734

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@mistic
skip flaky suite (elastic#152204)
2a8ae9f
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@cnasikas @kibanamachine
[Cases] Fix case view participants tests (elastic#162612)
453d75b 
## Summary

I removed the participants' tests from
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

There were a few things being tested:

| Old Test  | Where is it covered |
| ------------- | ------------- |
| should render the participants correctly  | Moved to an e2e test |
| should render Unknown users correctly  | Moved to  `UserList` |
| should render assignees in the participants section | Moved to an e2e
test |

I also added a small test for reporters.

Fixes elastic#152204
Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2734

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Fix case view participants tests cnasikas/kibana
4 participants
@mistic @cnasikas @elasticmachine @kibanamachine