-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preview chart in APM error rate and error count rules #159544
Fix preview chart in APM error rate and error count rules #159544
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/apm-ui (Team:APM) |
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
x-pack/test/apm_api_integration/tests/alerts/preview_chart_error_rate.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/tests/alerts/preview_chart_error_rate.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/apm_api_integration/tests/alerts/preview_chart_error_rate.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/routes/alerts/rule_types/utils/get_interval_in_seconds.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments that I think should be addressed
x-pack/plugins/apm/public/components/alerting/ui_components/chart_preview/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/alerting/ui_components/chart_preview/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/alerting/ui_components/chart_preview/index.tsx
Outdated
Show resolved
Hide resolved
.../plugins/apm/public/components/alerting/ui_components/chart_preview/chart_preview_helper.tsx
Show resolved
Hide resolved
.../plugins/apm/public/components/alerting/ui_components/chart_preview/chart_preview_helper.tsx
Outdated
Show resolved
Hide resolved
.../plugins/apm/public/components/alerting/ui_components/chart_preview/chart_preview_helper.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/alerting/ui_components/chart_preview/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/alerting/ui_components/chart_preview/index.tsx
Show resolved
Hide resolved
...k/plugins/apm/server/routes/alerts/rule_types/utils/get_filtered_series_for_preview_chart.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @benakansara |
x-pack/plugins/apm/server/routes/alerts/rule_types/error_count/get_error_count_chart_preview.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments made. lgtm. Thanks for all the work @benakansara !
Resolves the following for APM Failed transaction rate and APM Error count rules:
Improvements in the preview chart: