Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview chart in APM error rate and error count rules #159544

Merged

Conversation

benakansara
Copy link
Contributor

Resolves the following for APM Failed transaction rate and APM Error count rules:

Improvements in the preview chart:

  • Showing data grouped by selected group by fields
  • Showing 5 groups from each bucket
  • Showing last x units (minutes, hours, etc.) data
  • Added loading indicator
  • Showing tooltip
  • Always showing legend
  • Max Y is slightly higher than maximum of highest y value or threshold
  • Adjusting chart to always show the threshold line
  • Fixed
    • When removing some fields like transaction type, transaction name, chart showed no data
    • Hiding a particular group (by clicking on legend item), readjusted max Y value, but same was not reset to original when enabling the group back

@benakansara benakansara added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels Jun 13, 2023
@benakansara benakansara requested a review from a team June 13, 2023 08:22
@benakansara benakansara self-assigned this Jun 13, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@benakansara benakansara marked this pull request as ready for review June 13, 2023 10:25
@benakansara benakansara requested a review from a team as a code owner June 13, 2023 10:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments that I think should be addressed

@benakansara benakansara requested a review from sorenlouv June 19, 2023 11:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1405 1406 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB +8.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments made. lgtm. Thanks for all the work @benakansara !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants