refactoring

elastic · Jun 15, 2023 · d23a7f4 · d23a7f4
1 parent aaa7e04
commit d23a7f4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/x-pack/plugins/apm/common/rules/apm_rule_types.ts b/x-pack/plugins/apm/common/rules/apm_rule_types.ts
@@ -47,8 +47,6 @@ export interface PreviewChartResponseItem {
   data: Array<{ x: number; y: number | null }>;
 }
 
-export type PreviewChartResponse = PreviewChartResponseItem[];
-
 export const THRESHOLD_MET_GROUP_ID = 'threshold_met';
 export type ThresholdMetActionGroupId = typeof THRESHOLD_MET_GROUP_ID;
 const THRESHOLD_MET_GROUP: ActionGroup<ThresholdMetActionGroupId> = {

diff --git a/x-pack/plugins/apm/server/routes/alerts/route.ts b/x-pack/plugins/apm/server/routes/alerts/route.ts
@@ -16,7 +16,7 @@ import { createApmServerRoute } from '../apm_routes/create_apm_server_route';
 import { environmentRt, rangeRt } from '../default_api_types';
 import {
   AggregationType,
-  PreviewChartResponse,
+  PreviewChartResponseItem,
 } from '../../../common/rules/apm_rule_types';
 import { getApmEventClient } from '../../lib/helpers/get_apm_event_client';
 
@@ -42,6 +42,7 @@ const alertParamsRt = t.intersection([
   }),
 ]);
 
+export type PreviewChartResponse = PreviewChartResponseItem[];
 export type AlertParams = t.TypeOf<typeof alertParamsRt>;
 
 const transactionErrorRateChartPreview = createApmServerRoute({

diff --git a/.../plugins/apm/server/routes/alerts/rule_types/error_count/get_error_count_chart_preview.ts b/.../plugins/apm/server/routes/alerts/rule_types/error_count/get_error_count_chart_preview.ts
@@ -12,15 +12,12 @@ import {
   PROCESSOR_EVENT,
   SERVICE_NAME,
 } from '../../../../../common/es_fields/apm';
-import { AlertParams } from '../../route';
+import { AlertParams, PreviewChartResponse } from '../../route';
 import { environmentQuery } from '../../../../../common/utils/environment_query';
 import { APMEventClient } from '../../../../lib/helpers/create_es_client/create_apm_event_client';
 import { getGroupByTerms } from '../utils/get_groupby_terms';
 import { getAllGroupByFields } from '../../../../../common/rules/get_all_groupby_fields';
-import {
-  ApmRuleType,
-  PreviewChartResponse,
-} from '../../../../../common/rules/apm_rule_types';
+import { ApmRuleType } from '../../../../../common/rules/apm_rule_types';
 
 export async function getTransactionErrorCountChartPreview({
   apmEventClient,

diff --git a/...utes/alerts/rule_types/transaction_error_rate/get_transaction_error_rate_chart_preview.ts b/...utes/alerts/rule_types/transaction_error_rate/get_transaction_error_rate_chart_preview.ts
@@ -6,18 +6,15 @@
  */
 
 import { rangeQuery, termQuery } from '@kbn/observability-plugin/server';
-import {
-  ApmRuleType,
-  PreviewChartResponse,
-} from '../../../../../common/rules/apm_rule_types';
+import { ApmRuleType } from '../../../../../common/rules/apm_rule_types';
 import {
   SERVICE_NAME,
   TRANSACTION_TYPE,
   TRANSACTION_NAME,
   EVENT_OUTCOME,
 } from '../../../../../common/es_fields/apm';
 import { environmentQuery } from '../../../../../common/utils/environment_query';
-import { AlertParams } from '../../route';
+import { AlertParams, PreviewChartResponse } from '../../route';
 import {
   getSearchTransactionsEvents,
   getDocumentTypeFilterForTransactions,