Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs onboarding] replace euiThemeVars usage #157729

Merged
merged 1 commit into from
May 15, 2023
Merged

[Logs onboarding] replace euiThemeVars usage #157729

merged 1 commit into from
May 15, 2023

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented May 15, 2023

This Pr is a follow up of PR#157008 and PR#157147.

Changes:

  1. Replaced usage of euiThemeVars by useEuiTheme and useEuiFontSize.
  2. e2e cloudId following cloud plugin format.

@yngrdyn yngrdyn requested a review from a team as a code owner May 15, 2023 13:52
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label May 15, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 35.4KB 35.4KB +10.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ogupte
ogupte approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@yngrdyn yngrdyn merged commit 37d9db0 into elastic:main May 15, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 15, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@yngrdyn @jasonrhodes
[Logs onboarding] replace euiThemeVars usage (#157729)
6f6c860 
This Pr is a follow up of
[PR#157008](#157008) and
[PR#157147](#157147).

Changes:

1. Replaced usage of `euiThemeVars` by `useEuiTheme` and
`useEuiFontSize`.
2. e2e cloudId following [cloud plugin
format](https://github.com/elastic/kibana/tree/main/x-pack/plugins/cloud#cloudid).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yngrdyn @apmmachine @kibana-ci @ogupte @kibanamachine