[Logs onboarding] custom logs - configure logs #157008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
ogupte
approved these changes
May 10, 2023
| .replace(/[\\\/]/, ''); | ||
| const filenameParts = filenameWithExt.split('.'); | ||
|
|
||
| return replaceSpecialChars(filenameParts[0]); |
There was a problem hiding this comment.
we could probably just use the node path module instead:
import path from 'path';
const { name } = path.parse(filepath); // `name` is the basename without the extension| }, | ||
| '.euiFormLabel > .euiFlexGroup > div:last-of-type': { | ||
| fontWeight: 'normal', | ||
| color: euiThemeVars.euiTextSubduedColor, |
There was a problem hiding this comment.
We should probably use:
import { useEuiTheme } from '@elastic/eui';
...
const { euiTheme } = useEuiTheme();and then set
{ color: euiTheme.colors.subduedText }Color values in euiThemeVars are not always the same as the EUI colors. In this case, dev tools shows the colors to be slightly off:
euiTheme.colors.subduedText: #81858f
euiThemeVars.euiTextSubduedColor: #7a7f89
yngrdyn
added a commit
that referenced
this pull request
May 15, 2023
This Pr is a follow up of [PR#157008](#157008) and [PR#157147](#157147). Changes: 1. Replaced usage of `euiThemeVars` by `useEuiTheme` and `useEuiFontSize`. 2. e2e cloudId following [cloud plugin format](https://github.com/elastic/kibana/tree/main/x-pack/plugins/cloud#cloudid).
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
This Pr is a follow up of [PR#157008](#157008) and [PR#157147](#157147). Changes: 1. Replaced usage of `euiThemeVars` by `useEuiTheme` and `useEuiFontSize`. 2. e2e cloudId following [cloud plugin format](https://github.com/elastic/kibana/tree/main/x-pack/plugins/cloud#cloudid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155964.
Screen.Recording.2023-05-09.at.11.43.46.mov