[Discover] Migrate session session initialization to state container #156957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kertal |
jughosta
approved these changes
May 22, 2023
| createSearchSessionRestorationDataProvider({ | ||
| appStateContainer, | ||
| data: services.data, | ||
| getSavedSearch: () => savedSearchContainer.getState(), |
There was a problem hiding this comment.
Wonder if this logic should be executed again when savedSearchContainer state changes.
There was a problem hiding this comment.
It's just using id and name of a saved search when it's needed to name a search session ...
So it should be fine, but I bet this code can be improved a bit in the future :)
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
…lastic#156957) ## Summary Migrate `useSearchSession` to state container's `initializeAndSync` function, to remove another `hook`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #153528, migrate
useSearchSessionto state container'sinitializeAndSyncfunction, to remove anotherhookthat's redundant now.Checklist