[Discover] Add DiscoverSavedSearchContainer #153528

kertal · 2023-03-23T10:38:26Z

Summary

This PR adds the new DiscoverSavedSearchContainer. It fundamentally changes the way Discover treats the handling of the actual saved search.

Before this PR the saved search was updated only when data was fetched or when it was persisted or shared. With this PR, it's updated but not persisted with every relevant depending state change (user changing query, user showing/hiding the histogram, ...).
In the new DiscoverSavedSearchContainer we store the initial and the updated version. This allows us diff between both versions and can be used to provide an indication in the UI that there have been changes to the saved search, removing a common pain point in Discover (One it's implemented)
Generally DiscoverState has been initialized 2 times before this PR, now it's a singleton high up in the component tree, so when Discover Main is displayed it's just initialized 1x.
We accessed the savedSearch seachSource a lot in the UI before this PR, no this this much more limited

Context

This is the final PR refactoring Discover's state management, that was scattered around the code base (saved search, appState, dataState via observables), it's cleaning, and centralizing stuff. Its focus is to get a clearer structure, better separation from UI, removing of hook dependencies making it hard to debug the code. So refactoring without regressions, which makes it easier to further migrate to a future state management solution if needed. One of the biggest advantage is that we can now write unit test what kind of URL creates which kind of state and triggers which behavior.

Generally, the state container consists of several other state containers

kibana/src/plugins/discover/public/application/main/services/discover_state.ts

Lines 70 to 98 in 2d8a2b5

    
           export interface DiscoverStateContainer { 
        
             /** 
        
              * App state, the _a part of the URL 
        
              */ 
        
             appState: DiscoverAppStateContainer; 
        
             /** 
        
              * Data fetching related state 
        
              **/ 
        
             dataState: DiscoverDataStateContainer; 
        
             /** 
        
              * Internal state that's used at several places in the UI 
        
              */ 
        
             internalState: DiscoverInternalStateContainer; 
        
             /** 
        
              * kbnUrlStateStorage - it keeps the state in sync with the URL 
        
              */ 
        
             kbnUrlStateStorage: IKbnUrlStateStorage; 
        
             /** 
        
              * State of saved search, the saved object of Discover 
        
              */ 
        
             savedSearchState: DiscoverSavedSearchContainer; 
        
             /** 
        
              * Service for handling search sessions 
        
              */ 
        
             searchSessionManager: DiscoverSearchSessionManager; 
        
             /** 
        
              * Complex functions to update multiple containers from UI 
        
              */ 
        
             actions: {

Those can be directly accessed by the UI. For complex state manipulation which need more sub states, actions can be used from the UI

kibana/src/plugins/discover/public/application/main/services/discover_state.ts

Lines 98 to 175 in 2d8a2b5

    
             actions: { 
        
               /** 
        
                * Triggers fetching of new data from Elasticsearch 
        
                * If initial is true, then depending on the given configuration no fetch is triggered 
        
                * @param initial 
        
                */ 
        
               fetchData: (initial?: boolean) => void; 
        
               /** 
        
                * Initialize state with filters and query,  start state syncing 
        
                */ 
        
               initializeAndSync: () => () => void; 
        
               /** 
        
                * Load current list of data views, add them to internal state 
        
                */ 
        
               loadDataViewList: () => Promise<void>; 
        
               /** 
        
                * Load a saved search by id or create a new one that's not persisted yet 
        
                * @param savedSearchId 
        
                * @param dataView 
        
                */ 
        
               loadSavedSearch: ( 
        
                 savedSearchId?: string | undefined, 
        
                 dataView?: DataView | undefined, 
        
                 dataViewSpec?: DataViewSpec 
        
               ) => Promise<SavedSearch | undefined>; 
        
               /** 
        
                * Create and select a ad-hoc data view by a given index pattern 
        
                * @param pattern 
        
                */ 
        
               onCreateDefaultAdHocDataView: (pattern: string) => Promise<void>; 
        
               /** 
        
                * Triggered when a new data view is created 
        
                * @param dataView 
        
                */ 
        
               onDataViewCreated: (dataView: DataView) => Promise<void>; 
        
               /** 
        
                * Triggered when a new data view is edited 
        
                * @param dataView 
        
                */ 
        
               onDataViewEdited: (dataView: DataView) => Promise<void>; 
        
               /** 
        
                * Triggered when a saved search is opened in the savedObject finder 
        
                * @param savedSearchId 
        
                */ 
        
               onOpenSavedSearch: (savedSearchId: string) => void; 
        
               /** 
        
                * Triggered when the unified search bar query is updated 
        
                * @param payload 
        
                * @param isUpdate 
        
                */ 
        
               onUpdateQuery: ( 
        
                 payload: { dateRange: TimeRange; query?: Query | AggregateQuery }, 
        
                 isUpdate?: boolean 
        
               ) => void; 
        
               /** 
        
                * Triggered when the user selects a different data view in the data view picker 
        
                * @param id 
        
                */ 
        
               onChangeDataView: (id: string) => Promise<void>; 
        
               /** 
        
                * Triggered when an ad-hoc data view is persisted to allow sharing links and CSV 
        
                * @param dataView 
        
                */ 
        
               persistAdHocDataView: (dataView: DataView) => Promise<DataView>; 
        
               /** 
        
                * Set the currently selected data view 
        
                */ 
        
               setDataView: (dataView: DataView) => void; 
        
               /** 
        
                * Undo changes made to the saved search 
        
                */ 
        
               undoChanges: () => void; 
        
               /** 
        
                * When saving a saved search with an ad hoc data view, a new id needs to be generated for the data view 
        
                * This is to prevent duplicate ids messing with our system 
        
                */ 
        
               updateAdHocDataViewId: () => void; 
        
             };

With this state container we can write unit tests like e.g. for the loadSavedSearch action

kibana/src/plugins/discover/public/application/main/services/discover_state.test.ts

Lines 392 to 403 in 2d8a2b5

    
           test('loadSavedSearch data view handling', async () => { 
        
             const { state } = await getState('/', savedSearchMock); 
        
             await state.actions.loadSavedSearch(savedSearchMock.id); 
        
             expect(state.savedSearchState.getState().searchSource.getField('index')?.id).toBe( 
        
               'the-data-view-id' 
        
             ); 
        
             state.savedSearchState.load = jest.fn().mockReturnValue(savedSearchMockWithTimeField); 
        
             await state.actions.loadSavedSearch('the-saved-search-id-with-timefield'); 
        
             expect(state.savedSearchState.getState().searchSource.getField('index')?.id).toBe( 
        
               'index-pattern-with-timefield-id' 
        
             ); 
        
           });

Reviewing

First dear reviewer, apologies, this is a big PR ... but also, if I would have opened the initial draft PR fro review ... it would have been much worse. So, the best way to start reviewing is the first commit, which is introducing the new state container:

071fa37

And since the creator of this PR has been working on that for a while, he might not see the fires for tree.
There's certainly potential for follow up improvements, but it was time to bring the scope over the finishing line. Ideally we could use this state container also in the saved search embeddable, but this is Zukunfsmusik (🚀 🎼 )

Testing

The new version needs to be tested for regressions. Functional tests caught lots of stuff during development, not only Discover tests, also ML & alerting test were helpful. Nothing should have changed but since it's also a fundamental change, more testing is better than less. What should be tested

using the New menu bar entry to create new saved searches (ideally after loading persisted ones)
persisting a new saved search, editing it, saving it, switching to New, loading the saved search
creating alert rules
creating CSVs
Sharing URLs

Resolves #142131
Fixes #155193

Checklist

Unit or functional tests were updated or added to match the most common scenarios

- A container to centralize functionality around the usage of saved searches in Discover

kertal · 2023-03-23T12:38:28Z

src/plugins/discover/public/application/main/services/discover_saved_search_container.ts

+ * Can also be used to track changes to the saved search
+ * It centralizes functionality that was spread across the Discover main codebase
+ */
+export interface DiscoverSavedSearchContainer {


Dear reviewer, my I introduce the new (sub) state container to you ... most of the code in this PR is about using this ... so this is the ❤️ of the PR

elasticmachine · 2023-03-23T12:42:32Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal · 2023-03-23T12:44:32Z

src/plugins/discover/public/application/main/discover_main_route.tsx

+  const stateContainer = useSingleton<DiscoverStateContainer>(() =>
+    getDiscoverStateContainer({
+      history,
+      services,
+    })
+  );


Apart from adding a new state container, this is the biggest change, before this, DiscoverStateContainer was initialized 2x on every change to different saved search

kertal · 2023-03-23T12:48:45Z

src/plugins/discover/public/application/main/discover_main_app.tsx

   */
-  useEffect(() => {


I've heard rumors that useEffect isn't popular anymore (right @mattkime ), happy to say, that I removed some, and there might be potential for more ... oh yes, there a big hook gone use_discover_state, 👋 goodbye and thx for all the fish.

ok, this effect is a bad example because it was just moved to L90 😄

kertal · 2023-03-23T12:56:37Z

src/plugins/discover/public/application/main/components/field_stats_table/field_stats_tab.tsx

@@ -17,10 +18,12 @@ export const FieldStatisticsTab: React.FC<Omit<FieldStatisticsTableProps, 'query
    const querySubscriberResult = useQuerySubscriber({
      data: services.data,
    });
+    const savedSearch = useSavedSearch();


why not using the state container here ... it's not available in the saved search embeddable

jughosta

Wow! So many changes! Leaving some questions to clarify 💫

src/plugins/discover/public/__mocks__/saved_search.ts

src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx

src/plugins/discover/public/application/main/components/top_nav/on_save_search.tsx

src/plugins/discover/public/application/main/components/top_nav/open_alerts_popover.tsx

src/plugins/discover/public/application/main/components/layout/discover_layout.tsx

jughosta · 2023-03-27T13:20:57Z

src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx

-  DiscoverLayoutProps,
-  'navigateTo' | 'savedSearch' | 'searchSource'
-> & {
+export type DiscoverTopNavProps = Pick<DiscoverLayoutProps, 'navigateTo'> & {


Top nav disappeared for me after adding a query and a filter:

this is odd, I couldn't reproduce ... were there any error message in console? can you reproduce? many thx!

yeah, also can't reproduce, sorry!

that's the hardest one, I suspect it broke for the same reason alerting broke, causing a silent exception here

src/plugins/discover/public/application/main/hooks/use_inspector.ts

src/plugins/discover/public/application/main/components/top_nav/open_alerts_popover.tsx

jughosta · 2023-03-27T13:25:41Z

src/plugins/discover/public/application/main/services/discover_data_state_container.ts

-  const initialFetchStatus = shouldSearchOnPageLoad
-    ? FetchStatus.LOADING
-    : FetchStatus.UNINITIALIZED;
+  const getInitialFetchStatus = () => {


When SEARCH_ON_PAGE_LOAD_SETTING is off, it still loads data on page refresh and after pressing New

Working on a fix, moving the listener for the / path, that creates a new saved search or resets an existing one to discover_main_route.tsx

5ba1e2b

The way it was implemented before caused a duplicate fetch command before ... will follow up, first CI needs to reply

The issue is still present

hmm, for me it seems fixed, something to follow up after 🥚 & 🇳🇱

@davismcphee I can't reproduce it, but this needs definitely another pair of 👀

Well, well, found and fixed it (needed a query to reproduce) 98efa69

Looks like this issue with ignored discover:searchOnPageLoad is happening again

We chatted "offline" and it was because the refresh interval was "On" ... So it works like before. However me might consider, switching the refresh interval to "Off" when triggering New ... When I start a new search I think I first want to apply data, query, filter, before I want to have the data refreshed? ... not part of this PR of course

kertal · 2023-03-28T08:54:03Z

Wow! So many changes! Leaving some questions to clarify 💫

Yes, sorry for that, also seems I rushed to the review state. Apologies for that. Flagging it to draft again, until fixes are applied, 🙇 thx a lot for this first review!

- redundant, reducing the scope

kertal · 2023-05-02T05:57:25Z

@elasticmachine merge upstream

jughosta · 2023-05-02T08:26:46Z

src/plugins/discover/public/application/main/utils/resolve_data_view.ts

@@ -141,21 +145,45 @@ export function resolveDataView(
      });
      return ownDataView;
    }
-    if (!Boolean(isTextBasedQuery)) {


Was this condition redundant?

No, it wasn't but I guess it was a change that got lost since it was added during the long period of time of this PR ... This message doesn't make sense when loading a new saved search with SQL in the state URL. I reverted this change to consider text based queries , also added a test for it: 53ec89d

jughosta · 2023-05-02T09:06:13Z

src/plugins/discover/public/application/main/services/discover_data_state_container.ts

-  const initialFetchStatus = shouldSearchOnPageLoad
-    ? FetchStatus.LOADING
-    : FetchStatus.UNINITIALIZED;
+  const getInitialFetchStatus = () => {


Looks like this issue with ignored discover:searchOnPageLoad is happening again

… sql/esql

…ch-state

kertal · 2023-05-04T06:27:13Z

@elasticmachine merge upstream

jughosta

Did another test round: looking good! 👍
Thanks for improving the state management!

kertal · 2023-05-04T14:52:35Z

@jughosta thx a lot for taking care of this 🐰 🕳️ in terms of a review, for catching so much stuff 👍
@davismcphee no priority, but a final look at this would be great, because the size of this justifies 2 LGTM , many thx 🙇

davismcphee · 2023-05-05T02:49:05Z

@jughosta thx a lot for taking care of this 🐰 🕳️ in terms of a review, for catching so much stuff 👍 @davismcphee no priority, but a final look at this would be great, because the size of this justifies 2 LGTM , many thx 🙇

@kertal I was planning on doing a final review/round of testing on this today but didn't get the chance -- will definitely take a look at it tomorrow though!

davismcphee

Just finished a final round of reviewing and testing, and I'm happy to say it LGTM 🥳 That was a long time coming, but this was much needed work and I'm excited to finally see it merged to main. It's also good that it's early in the minor so we have time to catch and fix anything we might have missed. Great work, and I'd say we're good to push the button whenever you're ready!

kertal · 2023-05-07T21:45:23Z

@elasticmachine merge upstream

kibana-ci · 2023-05-07T22:47:16Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discover`	460	462	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`discover`	77	75	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	426.2KB	423.8KB	-2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedSearch`	5.5KB	5.6KB	+52.0B

Unknown metric groups

API count

id	before	after	diff
`savedSearch`	55	58	+3

ESLint disabled line counts

id	before	after	diff
`discover`	39	40	+1
`enterpriseSearch`	19	21	+2
`securitySolution`	398	401	+3
total			+6

References to deprecated APIs

id	before	after	diff
`discover`	27	29	+2

Total ESLint disabled count

id	before	after	diff
`discover`	39	40	+1
`enterpriseSearch`	20	22	+2
`securitySolution`	478	481	+3
total			+6

History

💚 Build #125735 succeeded 1b0c2f3
💚 Build #125389 succeeded bfe1cdd
💚 Build #125064 succeeded e0b7dac
💛 Build #125013 was flaky 2d25e73
💔 Build #125008 failed 53ec89d
💛 Build #124665 was flaky 91eee9e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

kertal · 2023-05-08T07:24:00Z

Thx so much @jughosta @davismcphee for taking care of the reviews of this 👹 🙇

## Summary Fixes an issue introduced #153528 by removing a change introduced in #156652 that enables sharing for text-based languages

Add DiscoverSavedSearchContainer

071fa37

- A container to centralize functionality around the usage of saved searches in Discover

kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Mar 23, 2023

kertal self-assigned this Mar 23, 2023

kertal added the ci:cloud-deploy Create or update a Cloud deployment label Mar 23, 2023

Make use of DiscoverSavedSearchContainer

2d8a2b5

kertal mentioned this pull request Mar 23, 2023

[Discover] Create enhanced central state container #140765

Closed

2 tasks

kertal added the release_note:skip Skip the PR/issue when compiling release notes label Mar 23, 2023

kertal commented Mar 23, 2023

View reviewed changes

kertal marked this pull request as ready for review March 23, 2023 12:42

kertal requested a review from a team as a code owner March 23, 2023 12:42

kertal commented Mar 23, 2023

View reviewed changes

Merge branch 'main' into discover-saved-search-state

e57af30

jughosta reviewed Mar 27, 2023

View reviewed changes

kertal added 4 commits March 28, 2023 07:25

Undo changes to field_stats_table.tsx

a28099a

Fix issue causing Inspector to show an empty title

10b7cd7

Add title to mock for testing

b36e2d8

Undo compressed property in table.tsx

8ddefa4

kertal marked this pull request as draft March 28, 2023 08:32

Move URL listener for / to discover_main_route.tsx

5ba1e2b

kertal added 6 commits March 28, 2023 12:41

Merge main, fix conflicts

eb99c5d

Attempt to fix tests failing due to filters

fb89c59

Undo alerting changes

5f70a9b

Improve useUrl usage

46b8d91

Fix saveDataSource to throw an error when needed

4f37e5d

Fix alerting UI exception

2cb0234

kertal added 5 commits April 28, 2023 10:28

Merge main, fix conflicts

5998584

Fix invalid import after merge

55e1136

Restore filter validation

3e72907

Undo histogram functional minor changes

db91451

Undo translation and functional change

3d60692

- redundant, reducing the scope

kertal requested review from jughosta and davismcphee April 28, 2023 12:50

Merge branch 'main' into discover-saved-search-state

91eee9e

jughosta reviewed May 2, 2023

View reviewed changes

kertal added 3 commits May 3, 2023 06:40

Implement no resolving of data views when loading saved searches with…

53ec89d

… sql/esql

Reset mock in jest test

2d25e73

Merge remote-tracking branch 'upstream/main' into discover-saved-sear…

e0b7dac

…ch-state

Merge branch 'main' into discover-saved-search-state

bfe1cdd

jughosta approved these changes May 4, 2023

View reviewed changes

Merge main, fix conflicts

1b0c2f3

davismcphee approved these changes May 5, 2023

View reviewed changes

Merge branch 'main' into discover-saved-search-state

5736cfd

kertal merged commit 8f41ab0 into elastic:main May 8, 2023

kibanamachine added the v8.9.0 label May 8, 2023

kertal mentioned this pull request May 9, 2023

[Discover] Fix sharing for text based languages #157163

Merged

kertal added a commit that referenced this pull request May 10, 2023

[Discover] Fix sharing for text based languages (#157163)

3b64113

## Summary Fixes an issue introduced #153528 by removing a change introduced in #156652 that enables sharing for text-based languages

kertal mentioned this pull request May 15, 2023

[Discover] Migrate session session initialization to state container #156957

Merged

1 task

kertal mentioned this pull request Feb 7, 2025

[Discover session] State management #210160

Open

	export interface DiscoverStateContainer {
	/**
	* App state, the _a part of the URL
	*/
	appState: DiscoverAppStateContainer;
	/**
	* Data fetching related state
	**/
	dataState: DiscoverDataStateContainer;
	/**
	* Internal state that's used at several places in the UI
	*/
	internalState: DiscoverInternalStateContainer;
	/**
	* kbnUrlStateStorage - it keeps the state in sync with the URL
	*/
	kbnUrlStateStorage: IKbnUrlStateStorage;
	/**
	* State of saved search, the saved object of Discover
	*/
	savedSearchState: DiscoverSavedSearchContainer;
	/**
	* Service for handling search sessions
	*/
	searchSessionManager: DiscoverSearchSessionManager;
	/**
	* Complex functions to update multiple containers from UI
	*/
	actions: {

	actions: {
	/**
	* Triggers fetching of new data from Elasticsearch
	* If initial is true, then depending on the given configuration no fetch is triggered
	* @param initial
	*/
	fetchData: (initial?: boolean) => void;
	/**
	* Initialize state with filters and query, start state syncing
	*/
	initializeAndSync: () => () => void;
	/**
	* Load current list of data views, add them to internal state
	*/
	loadDataViewList: () => Promise<void>;
	/**
	* Load a saved search by id or create a new one that's not persisted yet
	* @param savedSearchId
	* @param dataView
	*/
	loadSavedSearch: (
	savedSearchId?: string \| undefined,
	dataView?: DataView \| undefined,
	dataViewSpec?: DataViewSpec
	) => Promise<SavedSearch \| undefined>;
	/**
	* Create and select a ad-hoc data view by a given index pattern
	* @param pattern
	*/
	onCreateDefaultAdHocDataView: (pattern: string) => Promise<void>;
	/**
	* Triggered when a new data view is created
	* @param dataView
	*/
	onDataViewCreated: (dataView: DataView) => Promise<void>;
	/**
	* Triggered when a new data view is edited
	* @param dataView
	*/
	onDataViewEdited: (dataView: DataView) => Promise<void>;
	/**
	* Triggered when a saved search is opened in the savedObject finder
	* @param savedSearchId
	*/
	onOpenSavedSearch: (savedSearchId: string) => void;
	/**
	* Triggered when the unified search bar query is updated
	* @param payload
	* @param isUpdate
	*/
	onUpdateQuery: (
	payload: { dateRange: TimeRange; query?: Query \| AggregateQuery },
	isUpdate?: boolean
	) => void;
	/**
	* Triggered when the user selects a different data view in the data view picker
	* @param id
	*/
	onChangeDataView: (id: string) => Promise<void>;
	/**
	* Triggered when an ad-hoc data view is persisted to allow sharing links and CSV
	* @param dataView
	*/
	persistAdHocDataView: (dataView: DataView) => Promise<DataView>;
	/**
	* Set the currently selected data view
	*/
	setDataView: (dataView: DataView) => void;
	/**
	* Undo changes made to the saved search
	*/
	undoChanges: () => void;
	/**
	* When saving a saved search with an ad hoc data view, a new id needs to be generated for the data view
	* This is to prevent duplicate ids messing with our system
	*/
	updateAdHocDataViewId: () => void;
	};

	test('loadSavedSearch data view handling', async () => {
	const { state } = await getState('/', savedSearchMock);
	await state.actions.loadSavedSearch(savedSearchMock.id);
	expect(state.savedSearchState.getState().searchSource.getField('index')?.id).toBe(
	'the-data-view-id'
	);
	state.savedSearchState.load = jest.fn().mockReturnValue(savedSearchMockWithTimeField);
	await state.actions.loadSavedSearch('the-saved-search-id-with-timefield');
	expect(state.savedSearchState.getState().searchSource.getField('index')?.id).toBe(
	'index-pattern-with-timefield-id'
	);
	});

[Discover] Add DiscoverSavedSearchContainer #153528

[Discover] Add DiscoverSavedSearchContainer #153528

Conversation

kertal commented Mar 23, 2023 • edited Loading

Summary

Context

Reviewing

Testing

Checklist

kertal Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Mar 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jughosta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jughosta May 2, 2023 • edited Loading

Choose a reason for hiding this comment

kertal May 4, 2023 • edited Loading

Choose a reason for hiding this comment

kertal commented Mar 28, 2023

kertal commented May 2, 2023

Choose a reason for hiding this comment

kertal May 3, 2023 • edited Loading

Choose a reason for hiding this comment

jughosta May 2, 2023 • edited Loading

Choose a reason for hiding this comment

kertal commented May 4, 2023

jughosta left a comment

Choose a reason for hiding this comment

kertal commented May 4, 2023 • edited Loading

davismcphee commented May 5, 2023

davismcphee left a comment

Choose a reason for hiding this comment

kertal commented May 7, 2023

kibana-ci commented May 7, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

kertal commented May 8, 2023

kertal commented Mar 23, 2023 •

edited

Loading

kertal Mar 23, 2023 •

edited

Loading

jughosta May 2, 2023 •

edited

Loading

kertal May 4, 2023 •

edited

Loading

kertal May 3, 2023 •

edited

Loading

jughosta May 2, 2023 •

edited

Loading

kertal commented May 4, 2023 •

edited

Loading