-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Enhances support for counter fields in data visualizer / field statistics #153893
Conversation
Pinging @elastic/ml-ui (:ml) |
0c06b17
to
34a7f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good, but left a couple of suggestions for follow up work.
...plugins/data_visualizer/public/application/index_data_visualizer/utils/get_supported_aggs.ts
Outdated
Show resolved
Hide resolved
...plugins/data_visualizer/public/application/index_data_visualizer/utils/get_supported_aggs.ts
Outdated
Show resolved
Hide resolved
...ins/data_visualizer/public/application/common/components/field_type_icon/field_type_icon.tsx
Show resolved
Hide resolved
...plugins/data_visualizer/public/application/index_data_visualizer/utils/get_supported_aggs.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM.
I flipped the release note label to enhancement
and edited the PR title.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @qn895 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM ⚡
Summary
Follow up of #152898 and addresses #153050. This PR adds better support for time series metric
counter
field. It also temporarily adds a list of supported elasticsearch aggregations for each field type (until elastic/elasticsearch#93884 or equivalent is merged in).Currently, it will support
count
,min
, andmax
aggs.It will also not show cardinality instead of showing it as 0 when not available.
It also supports new field types like gauge and counter in the field type filters.
Going to Lens will also use maximum operation instead of average, depending on what the field type supports.
Screen.Recording.2023-03-29.at.13.34.36.mov
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers