Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][tsdb] Treat time series counter field as non aggregatable in Index data visualizer #152898

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Mar 8, 2023

Summary

Treats time series counter metric field as non aggregatable inside data visualizer, since required aggregations are not supported on such field.

@ppisljar ppisljar marked this pull request as ready for review March 8, 2023 11:34
@ppisljar ppisljar requested a review from a team as a code owner March 8, 2023 11:34
@ppisljar ppisljar mentioned this pull request Mar 8, 2023
4 tasks
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.8.0 labels Mar 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Mar 21, 2023

Tested latest changes with 2023-03-20 elasticsearch snapshot and patch from #152721 and no longer run into the error. However, doesn't seem like dataViewFields.filter((f) => f.timeSeriesMetric === 'counter') currently yields any field, so not sure if this fix is what addresses the issue.

@ppisljar
Copy link
Member Author

in our logs sample dataset there are no tsdb counter fields (the dataset is not time series dataset at all).
we discussed offline on how to get sample data imported that contains such fields

@qn895 qn895 changed the title [tsdb] treat time series counter field as non aggregatable in data visualizer [ML][tsdb] Treat time series counter field as non aggregatable in Index data visualizer Mar 22, 2023
@qn895 qn895 self-assigned this Mar 22, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 366.1KB 366.1KB +34.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants