Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pipeline creation endpoint accept a full pipeline definition #153133

Conversation

seanstory
Copy link
Member

Summary

Updates ML Inference Pipeline creation for Enterprise Search to accept either a full pipeline definition OR several distinct parameters (modelId, sourceField, destinationField). This will make it easier to create more complex pipelines without having to continue to grow this API, and will also enable future end-user editing of the pipeline JSON.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@seanstory seanstory requested review from TattdCodeMonkey, demjened and a team March 10, 2023 20:57
@seanstory seanstory added the release_note:skip Skip the PR/issue when compiling release notes label Mar 10, 2023
@seanstory seanstory force-pushed the seanstory/4140-update-pipeline-api-to-accept-full-definition branch from e041332 to 0d57c90 Compare March 10, 2023 21:24
@seanstory seanstory force-pushed the seanstory/4140-update-pipeline-api-to-accept-full-definition branch from f49addd to 7624188 Compare March 20, 2023 14:31
@seanstory seanstory enabled auto-merge (squash) March 20, 2023 14:32
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +42.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

  • 💔 Build #113455 failed f49addd8c12a93ac21a59ded5cd8167d180b1e3f
  • 💔 Build #113448 failed e04133249acff2de5a45575469d01f609a5fa784

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@seanstory seanstory merged commit 52d2b0d into elastic:main Mar 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 20, 2023
v1v added a commit to v1v/kibana that referenced this pull request Mar 20, 2023
…loy-my-kibana-oblt

* upstream/main: (727 commits)
  Upgrade caniuse-lite db (elastic#153318)
  [Security Solution] expanded flyout - right section - json tab implementation (elastic#152935)
  chore(slo): Make APM indicator's index required (elastic#153311)
  skip failing test suite (elastic#136688)
  [Security Solution] Fix security-solution storybook package codeowners (elastic#153307)
  [EUI] Add `scrollLock` workaround CSS to Kibana's `body` (elastic#153227)
  [Cloud Security] Show coming soon deployments of vulnerability management (elastic#153249)
  [Cloud Security] fixed onboarding link directs to cspm integration (elastic#153268)
  [Response Ops][Alerting] Reusable functions for FAAD resource installation (elastic#152849)
  remove geohash_grid aggregation support (elastic#152952)
  [Tech Debt] Reorder Rules page (elastic#152897)
  [Saved Object Finder] Add help text & left button (elastic#152742)
  [Transform] Replace SavedObjectsFinder component (elastic#153128)
  Make pipeline creation endpoint accept a full pipeline definition (elastic#153133)
  [Fleet] Displaying policy changes in Agent activity (elastic#153237)
  skip flaky suite (elastic#152852)
  [Security Solution][Endpoint] Add tests to cover RBAC entries in the Role Kibana Privileges flyout (elastic#153068)
  [Security Solution][Endpoint] Additional tests for Response Console History Log page (covers TestRail manual tests) (elastic#153042)
  [Monitoring] Display node roles in Nodes table (elastic#152127)
  Rename getEditAlertFlyout to getEditRuleFlyout (elastic#153243)
  ...
@seanstory seanstory deleted the seanstory/4140-update-pipeline-api-to-accept-full-definition branch March 20, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants