Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Security API Integration Tests (Session Idle Timeout).x-pack/test/security_api_integration/tests/session_idle/extension·ts - security APIs - Session Idle Session POST /internal/security/session should extend the session #136688

Closed
kibanamachine opened this issue Jul 19, 2022 · 10 comments · Fixed by #153303
Closed

Failing test: X-Pack Security API Integration Tests (Session Idle Timeout).x-pack/test/security_api_integration/tests/session_idle/extension·ts - security APIs - Session Idle Session POST /internal/security/session should extend the session #136688

kibanamachine opened this issue Jul 19, 2022 · 10 comments · Fixed by #153303
Assignees
@thomheymann @jeramysoucy
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 19, 2022 •
edited
Loading

A test failed on a tracked branch

Error: expected 9930 to be above 9938
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (node_modules/@kbn/expect/expect.js:336:8)
    at Function.lessThan (node_modules/@kbn/expect/expect.js:531:15)
    at Context.<anonymous> (x-pack/test/security_api_integration/tests/session_idle/extension.ts:86:45)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 19, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 19, 2022
@kibanamachine kibanamachine added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Jul 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 19, 2022
@legrego
Copy link
Member

legrego commented Jul 20, 2022

@thomheymann I'm assigning this to you since you're on support rotation this week

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@thomheymann
Copy link
Contributor

Test has already been unskipped

@kibanamachine kibanamachine reopened this Mar 12, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jeramysoucy jeramysoucy self-assigned this Mar 20, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Mar 20, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 9bd8e2b

kibanamachine added a commit that referenced this issue Mar 20, 2023
@kibanamachine
skip failing test suite (#136688)
9bd8e2b
@jeramysoucy jeramysoucy mentioned this issue Mar 20, 2023
Merged
v1v added a commit to v1v/kibana that referenced this issue Mar 20, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/support-dep…
ddddab0 
…loy-my-kibana-oblt

* upstream/main: (727 commits)
  Upgrade caniuse-lite db (elastic#153318)
  [Security Solution] expanded flyout - right section - json tab implementation (elastic#152935)
  chore(slo): Make APM indicator's index required (elastic#153311)
  skip failing test suite (elastic#136688)
  [Security Solution] Fix security-solution storybook package codeowners (elastic#153307)
  [EUI] Add `scrollLock` workaround CSS to Kibana's `body` (elastic#153227)
  [Cloud Security] Show coming soon deployments of vulnerability management (elastic#153249)
  [Cloud Security] fixed onboarding link directs to cspm integration (elastic#153268)
  [Response Ops][Alerting] Reusable functions for FAAD resource installation (elastic#152849)
  remove geohash_grid aggregation support (elastic#152952)
  [Tech Debt] Reorder Rules page (elastic#152897)
  [Saved Object Finder] Add help text & left button (elastic#152742)
  [Transform] Replace SavedObjectsFinder component (elastic#153128)
  Make pipeline creation endpoint accept a full pipeline definition (elastic#153133)
  [Fleet] Displaying policy changes in Agent activity (elastic#153237)
  skip flaky suite (elastic#152852)
  [Security Solution][Endpoint] Add tests to cover RBAC entries in the Role Kibana Privileges flyout (elastic#153068)
  [Security Solution][Endpoint] Additional tests for Response Console History Log page (covers TestRail manual tests) (elastic#153042)
  [Monitoring] Display node roles in Nodes table (elastic#152127)
  Rename getEditAlertFlyout to getEditRuleFlyout (elastic#153243)
  ...
jeramysoucy added a commit that referenced this issue Mar 23, 2023
@jeramysoucy
Fixes session idle timeout API test (#153303)
fb67e5a 
Closes #152260
Closes #121482
Closes #136688

## Description
- Adds security index refresh to `getSessionInfo` to ensure each query
is running on updated data
- Triggers the cleanup routine just before checking idle session
timeouts to increase determinism (same methodology used in concurrent
sessions tests)
- Adds a short static delay when testing session extend to ensure the
original session time has somewhat elapsed (when this was failing it was
only by a few milliseconds)

### Tests
x-pack/test/security_api_integration/session_idle.config.ts...
- 'should properly clean up session expired because of idle timeout'
- 'should properly clean up session expired because of idle timeout when
providers override global session config'
- 'should extend the session'

### Flaky Test Runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2031
jennypavlova pushed a commit to jennypavlova/kibana that referenced this issue Mar 24, 2023
@jeramysoucy @jennypavlova
Fixes session idle timeout API test (elastic#153303)
bbab0f5 
Closes elastic#152260
Closes elastic#121482
Closes elastic#136688

## Description
- Adds security index refresh to `getSessionInfo` to ensure each query
is running on updated data
- Triggers the cleanup routine just before checking idle session
timeouts to increase determinism (same methodology used in concurrent
sessions tests)
- Adds a short static delay when testing session extend to ensure the
original session time has somewhat elapsed (when this was failing it was
only by a few milliseconds)

### Tests
x-pack/test/security_api_integration/session_idle.config.ts...
- 'should properly clean up session expired because of idle timeout'
- 'should properly clean up session expired because of idle timeout when
providers override global session config'
- 'should extend the session'

### Flaky Test Runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomheymann thomheymann

@jeramysoucy jeramysoucy

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes session idle timeout API test jeramysoucy/kibana
6 participants
@thomheymann @jbudz @legrego @elasticmachine @kibanamachine @jeramysoucy