-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecuritySolution] Replace risk score over time with Lens Embeddable #149035
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Angela! Thank you for updating the risk score over time chart.
I noticed that there are some donut chart code changes in the branch. Was it intentional?
domain={{ | ||
min: 0, | ||
max: 100, | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angorayc I made it look more similar to the previous design by setting max-min
to 0-100
. And removing the horizontal lines.
Is it possible to apply the same changes by configuration?
I also noticed that you are using the 'average' function for grouping and I believe that a 'maximum' function would fit better in this use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -71,6 +72,12 @@ export const DonutTextWrapper = styled(EuiFlexGroup)< | |||
max-width: 77px; | |||
position: absolute; | |||
z-index: 1; | |||
|
|||
&.risk-score { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CSS selector doesn't seem very maintainable. We shouldn't make references to specific pages or components from inside a generic donut chart. I would suggest to have a particular property for this behaviour, like emptyDataTopPosition
, or reuse the class you receive as props in the selector:
&.${donutTextWrapperClassName} {
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I have updated the css rules here, so we can just pass a custom class and the styles to the component.
Yes, it implements |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Thank you!
Summary
Implements: #149015
Please Enable feature flags. Please add this to kibana.dev.yml xpack.securitySolution.enableExperimental: ['chartEmbeddablesEnabled']
Replace risk score over time with Lens Embeddable
Before:

After:

Alerts By severity on host / network / user details should apply global filters
Styling for donuts on Entity Analytics dashboard
(Moving the legend to left side of the chart so its actions button wouldn't overlap with chart action)

Preview:
Host risk score over time
User risk score over time
https://p.elstc.co/paste/2MIN+pHd#TETZwPh15r64HQ2z0Cn26Z321XCxe+2DqliqF5-CHmr
Designers' review:
#149123
Known issue:
#149513
Checklist
Delete any items that are not applicable to this PR.