Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Designer's review and redesign on migration to Lens Embeddables #149123

Closed
angorayc opened this issue Jan 18, 2023 · 3 comments
Closed

[SecuritySolution] Designer's review and redesign on migration to Lens Embeddables #149123

angorayc opened this issue Jan 18, 2023 · 3 comments
Assignees
@codearos @ferenrigue
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0

Comments

@angorayc
Copy link
Contributor

angorayc commented Jan 18, 2023 •
edited
Loading

Original issue: #136409 | #150531

We have most of the visualisations migrated to Lens Embeddable, please have a review on

Preview
https://kibana-pr-150531.kb.us-west2.gcp.elastic-cloud.com:9243/
https://p.elstc.co/paste/Ym09x3Zo#KnGQbWMwyslEZJThW82sle7QgCLPH5DT3KbhIoiwLUn

Please take these known issues into consideration to decide if redesign is required:
#136409 <Feature request on Lens' side>

Visualisations to review:

  1. Dashboards - overview: alert trend
  2. Dashboards - overview: events
  3. Dashboards - Detection & Response: Alerts not supported, [SecuritySolution] Follow up unsupported charts #149592 item 5
  4. Dashboards - Entity Analytics: Host Risk Scores not supported, [SecuritySolution] Follow up unsupported charts #149592 item 6
  5. Dashboards - Entity Analytics: User Risk Scores not supported, [SecuritySolution] Follow up unsupported charts #149592 item 6
  6. Alerts - Table
  7. Alerts - Trend
  8. Alerts - Treemap not supported, [SecuritySolution] Follow up unsupported charts #149592 item 1
  9. Alerts - Charts not supported, [SecuritySolution] Follow up unsupported charts #149592 item 2
  10. Rules - Alerts - Trend
  11. Rules creation - rule preview not supported, [SecuritySolution] Follow up unsupported charts #149592 item 4
  12. Explore - Hosts: KPI Hosts
  13. Explore - Hosts: Unique IPs
  14. Explore - Hosts: Events
  15. Explore - Host details: Alerts by Severity not supported, [SecuritySolution] Follow up unsupported charts #149592 item 5
  16. Explore - Host details: Authentications
  17. Explore - Host details: Events
  18. Explore - Host details: Host risk - Host risk score over time
  19. Explore - Network: KPI Network events
  20. Explore - Network: KPI DNS queries
  21. Explore - Network: KPI Unique flow IDs
  22. Explore - Network: KPI TLS handshakes
  23. Explore - Network: KPI Unique private IPs
  24. Explore - Network: DNS - Top domains by dns.question.registered_domain
  25. Explore - Network: Events
  26. Explore - Network details: Alerts by Severity not supported, [SecuritySolution] Follow up unsupported charts #149592 item 5
  27. Explore - Network details: Events
  28. Explore - Users: KPI Users
  29. Explore - Users: KPI user authentications
  30. Explore - Users: Authentications
  31. Explore - Users: Events
  32. Explore - User details: Alerts by Severity not supported, [SecuritySolution] Follow up unsupported charts #149592 item 5
  33. Explore - User details: Authentications
  34. Explore - User details: Events
  35. Explore - User details: User risk - User risk score over time
@angorayc angorayc mentioned this issue Jan 18, 2023
Closed
41 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 18, 2023
@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.7.0 labels Jan 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

This was referenced Jan 18, 2023
Merged
Closed
angorayc added a commit that referenced this issue Jan 24, 2023
@angorayc
[SecuritySolution] Replace risk score over time with Lens Embeddable (#…
7c4789d 
…149035)

## Summary
Implements: #149015

Please Enable feature flags. Please add this to kibana.dev.yml
xpack.securitySolution.enableExperimental: ['chartEmbeddablesEnabled']

---
### Replace risk score over time with Lens Embeddable

Before:
<img width="2543" alt="Screenshot 2023-01-17 at 10 28 23"
src="https://user-images.githubusercontent.com/6295984/212875145-f39fef08-c152-4c7e-8d0f-cf8e259c0b05.png">

After:
<img width="926" alt="Screenshot 2023-01-24 at 15 03 40"
src="https://user-images.githubusercontent.com/6295984/214329885-71e8166b-07ec-4f09-bece-919189d655ea.png">


### Alerts By severity on host / network / user details should apply
global filters
<img width="1673" alt="Screenshot 2023-01-19 at 11 06 21"
src="https://user-images.githubusercontent.com/6295984/213426977-4b803513-69f4-4074-b45d-2002c3f8fecf.png">

### Styling for donuts on Entity Analytics dashboard
(Moving the legend to left side of the chart so its actions button
wouldn't overlap with chart action)
<img width="1654" alt="Screenshot 2023-01-19 at 11 08 47"
src="https://user-images.githubusercontent.com/6295984/213427320-0fa3a9aa-f0d4-435a-87d3-5108b5c7f991.png">


Preview:
[Host risk score over
time](https://kibana-pr-148624.kb.us-west2.gcp.elastic-cloud.com:9243/s/data/app/security/hosts/name/Angelas-MacBook-Pro.local/hostRisk?sourcerer=(default:(id:security-solution-data,selectedPatterns:!(%27filebeat-*%27,%27logs-*%27,%27packetbeat-*%27,%27-*elastic-cloud-logs-*%27)))&timerange=(global:(linkTo:!(timeline),timerange:(from:%272023-01-18T00:00:00.000Z%27,fromStr:now%2Fd,kind:relative,to:%272023-01-18T23:59:59.999Z%27,toStr:now%2Fd)),timeline:(linkTo:!(global),timerange:(from:%272023-01-18T00:00:00.000Z%27,fromStr:now%2Fd,kind:relative,to:%272023-01-18T23:59:59.999Z%27,toStr:now%2Fd)))&timeline=(activeTab:query,graphEventId:%27%27,id:%2736333270-9731-11ed-a0f5-f16ed1963ee6%27,isOpen:!f))
[User risk score over
time](https://kibana-pr-148624.kb.us-west2.gcp.elastic-cloud.com:9243/s/data/app/security/users/name/angelachuang/userRisk?sourcerer=(default:(id:security-solution-data,selectedPatterns:!(%27filebeat-*%27,%27logs-*%27,%27packetbeat-*%27,%27-*elastic-cloud-logs-*%27)))&timerange=(global:(linkTo:!(timeline),timerange:(from:%272023-01-18T00:00:00.000Z%27,fromStr:now%2Fd,kind:relative,to:%272023-01-18T23:59:59.999Z%27,toStr:now%2Fd)),timeline:(linkTo:!(global),timerange:(from:%272023-01-18T00:00:00.000Z%27,fromStr:now%2Fd,kind:relative,to:%272023-01-18T23:59:59.999Z%27,toStr:now%2Fd)))&timeline=(activeTab:query,graphEventId:%27%27,id:%2736333270-9731-11ed-a0f5-f16ed1963ee6%27,isOpen:!f))

https://p.elstc.co/paste/2MIN+pHd#TETZwPh15r64HQ2z0Cn26Z321XCxe+2DqliqF5-CHmr
Designers' review:
#149123

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@angorayc angorayc mentioned this issue Jan 26, 2023
Open
@angorayc angorayc added v8.8.0 and removed v8.7.0 labels Feb 7, 2023
@angorayc angorayc mentioned this issue Feb 27, 2023
Merged
1 task
@ferenrigue
Copy link

Everything is really good. Approved by design.

@angorayc angorayc closed this as completed Mar 2, 2023
angorayc added a commit that referenced this issue Mar 7, 2023
@angorayc @kibanamachine
[SecuritySolution] Enable chartEmbeddablesEnabled feature flag (#150531)
0d8a1ec 
## Summary

**Original Issue**
#136409

**Preview**
https://kibana-pr-150531.kb.us-west2.gcp.elastic-cloud.com:9243/

https://p.elstc.co/paste/G+PhWdS0#WEyGBtMD9I4r74WPNIQFvgELZPOp-SZCG3yja1LOuwQ

**Migrated charts**
#149123

**Known issues of the Embeddables after enabling the feature flag:** 
#136409 (Feature request on
Lens’ side & Bugs section)

**Charts not supported by Lens Embeddable:**
#149592

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@angorayc @kibanamachine @bmorelli25
[SecuritySolution] Enable chartEmbeddablesEnabled feature flag (elast…
a53c6d2 
…ic#150531)

## Summary

**Original Issue**
elastic#136409

**Preview**
https://kibana-pr-150531.kb.us-west2.gcp.elastic-cloud.com:9243/

https://p.elstc.co/paste/G+PhWdS0#WEyGBtMD9I4r74WPNIQFvgELZPOp-SZCG3yja1LOuwQ

**Migrated charts**
elastic#149123

**Known issues of the Embeddables after enabling the feature flag:** 
elastic#136409 (Feature request on
Lens’ side & Bugs section)

**Charts not supported by Lens Embeddable:**
elastic#149592

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codearos codearos

@ferenrigue ferenrigue

Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@angorayc @elasticmachine @codearos @ferenrigue