Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] bundled packages - use package storage v2 for synthetics #146931

Merged
merged 3 commits into from
Dec 5, 2022
Merged

[Fleet] bundled packages - use package storage v2 for synthetics #146931

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a14ef
fleet - bundled packages - use package storage v2 for synthetics
dominiqueclarke Dec 2, 2022
ebdca36
Update src/dev/build/tasks/bundle_fleet_packages.ts
dominiqueclarke Dec 2, 2022
4231d0f
Merge branch 'main' into fix/fleet-bundled-packages-v2-synthetics
dominiqueclarke Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/dev/build/tasks/bundle_fleet_packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,12 @@ export const BundleFleetPackages: Task = {
const archivePath = `${fleetPackage.name}-${versionToWrite}.zip`;
let archiveUrl = `${eprUrl}/epr/${fleetPackage.name}/${fleetPackage.name}-${fleetPackage.version}.zip`;

// Point APM and Endpoint packages to package storage v2
if (fleetPackage.name === 'apm' || fleetPackage.name === 'endpoint') {
// Point APM, Endpoint and Synthetics packages to package storage v2
if (
fleetPackage.name === 'apm' ||
fleetPackage.name === 'endpoint' ||
fleetPackage.name === 'synthetics'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpollich is there a reason why we can't use v2 url for all packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will after the DNS is swapped over to point snapshot and staging to v2, but until then we still have these explicit checks. APM was using v2 before it was production-ready, so that's why there's this pattern.

It probably makes sense to remove all of this as part of #144096

) {
archiveUrl = `${PACKAGE_STORAGE_V2_URL}/epr/${fleetPackage.name}/${fleetPackage.name}-${fleetPackage.version}.zip`;
}

Expand Down