Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] bundled packages - use package storage v2 for synthetics #146931

Merged
merged 3 commits into from
Dec 5, 2022
Merged

[Fleet] bundled packages - use package storage v2 for synthetics #146931

merged 3 commits into from
Dec 5, 2022

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Dec 2, 2022 •
edited by kibanamachine
Loading

Summary

Relates to failures seen on #146823

Synthetics package is just published into package storage v2, so it requires to add an exception as it was done for the APM package.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0 v8.7.0 labels Dec 2, 2022
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner December 2, 2022 21:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@dominiqueclarke dominiqueclarke requested a review from a team December 2, 2022 21:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

juliaElastic
juliaElastic reviewed Dec 5, 2022
View reviewed changes
src/dev/build/tasks/bundle_fleet_packages.ts
if (
fleetPackage.name === 'apm' ||
fleetPackage.name === 'endpoint' ||
fleetPackage.name === 'synthetics'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpollich is there a reason why we can't use v2 url for all packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will after the DNS is swapped over to point snapshot and staging to v2, but until then we still have these explicit checks. APM was using v2 before it was production-ready, so that's why there's this pattern.

It probably makes sense to remove all of this as part of #144096

@dominiqueclarke dominiqueclarke merged commit e76171c into elastic:main Dec 5, 2022
@dominiqueclarke dominiqueclarke deleted the fix/fleet-bundled-packages-v2-synthetics branch December 5, 2022 14:02
@kibanamachine kibanamachine mentioned this pull request Dec 5, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2022
@dominiqueclarke
[Fleet] bundled packages - use package storage v2 for synthetics (ela…
d698903 
…stic#146931)

## Summary

Relates to failures seen on
elastic#146823

Synthetics package is just published into package storage v2, so it
requires to add an exception as it was done for the APM package.

(cherry picked from commit e76171c)
@kibanamachine kibanamachine mentioned this pull request Dec 5, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2022
@dominiqueclarke
[Fleet] bundled packages - use package storage v2 for synthetics (ela…
2782f39 
…stic#146931)

## Summary

Relates to failures seen on
elastic#146823

Synthetics package is just published into package storage v2, so it
requires to add an exception as it was done for the APM package.

(cherry picked from commit e76171c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 5, 2022
@kibanamachine @dominiqueclarke
[8.5] [Fleet] bundled packages - use package storage v2 for synthetics (
9454ffb 
#146931) (#146998)

# Backport

This will backport the following commits from `main` to `8.5`:
- [[Fleet] bundled packages - use package storage v2 for synthetics
(#146931)](#146931)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2022-12-05T14:02:07Z","message":"[Fleet]
bundled packages - use package storage v2 for synthetics (#146931)\n\n##
Summary\r\n\r\nRelates to failures seen
on\r\nhttps://github.com//pull/146823\r\n\r\nSynthetics
package is just published into package storage v2, so it\r\nrequires to
add an exception as it was done for the APM
package.","sha":"e76171cb9865a731810014d22febb6f42ead8c9a","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.6.0","v8.7.0","v8.5.3"],"number":146931,"url":"https://github.com/elastic/kibana/pull/146931","mergeCommit":{"message":"[Fleet]
bundled packages - use package storage v2 for synthetics (#146931)\n\n##
Summary\r\n\r\nRelates to failures seen
on\r\nhttps://github.com//pull/146823\r\n\r\nSynthetics
package is just published into package storage v2, so it\r\nrequires to
add an exception as it was done for the APM
package.","sha":"e76171cb9865a731810014d22febb6f42ead8c9a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146931","number":146931,"mergeCommit":{"message":"[Fleet]
bundled packages - use package storage v2 for synthetics (#146931)\n\n##
Summary\r\n\r\nRelates to failures seen
on\r\nhttps://github.com//pull/146823\r\n\r\nSynthetics
package is just published into package storage v2, so it\r\nrequires to
add an exception as it was done for the APM
package.","sha":"e76171cb9865a731810014d22febb6f42ead8c9a"}},{"branch":"8.5","label":"v8.5.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
kibanamachine added a commit that referenced this pull request Dec 5, 2022
@kibanamachine @dominiqueclarke
[8.6] [Fleet] bundled packages - use package storage v2 for synthetics (
e9cdbaa 
#146931) (#146999)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Fleet] bundled packages - use package storage v2 for synthetics
(#146931)](#146931)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2022-12-05T14:02:07Z","message":"[Fleet]
bundled packages - use package storage v2 for synthetics (#146931)\n\n##
Summary\r\n\r\nRelates to failures seen
on\r\nhttps://github.com//pull/146823\r\n\r\nSynthetics
package is just published into package storage v2, so it\r\nrequires to
add an exception as it was done for the APM
package.","sha":"e76171cb9865a731810014d22febb6f42ead8c9a","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.6.0","v8.7.0","v8.5.3"],"number":146931,"url":"https://github.com/elastic/kibana/pull/146931","mergeCommit":{"message":"[Fleet]
bundled packages - use package storage v2 for synthetics (#146931)\n\n##
Summary\r\n\r\nRelates to failures seen
on\r\nhttps://github.com//pull/146823\r\n\r\nSynthetics
package is just published into package storage v2, so it\r\nrequires to
add an exception as it was done for the APM
package.","sha":"e76171cb9865a731810014d22febb6f42ead8c9a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146931","number":146931,"mergeCommit":{"message":"[Fleet]
bundled packages - use package storage v2 for synthetics (#146931)\n\n##
Summary\r\n\r\nRelates to failures seen
on\r\nhttps://github.com//pull/146823\r\n\r\nSynthetics
package is just published into package storage v2, so it\r\nrequires to
add an exception as it was done for the APM
package.","sha":"e76171cb9865a731810014d22febb6f42ead8c9a"}},{"branch":"8.5","label":"v8.5.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@mistic
Copy link
Member

mistic commented Dec 8, 2022

This PR didn't make it into v8.5.3. Updating the labels.

@mistic mistic removed the v8.5.3 label Dec 8, 2022
@mistic mistic added the v8.5.4 label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich left review comments

@jbudz jbudz jbudz approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.4 v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @mistic @jbudz @kpollich @juliaElastic