Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SharedUX] Allow creation of adHoc data views from no data page #144596

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Nov 4, 2022

Summary

This PR is to address: #143676

This PR adds an optional property "allowAdHocDataView" to AnalyticsNoDataPage component, so it can be used from Discover to allow creation of ad hoc data views from data view editor.

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
    - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
    - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
    - [ ] This was checked for cross-browser compatibility

@majagrubic majagrubic changed the title [SharedUX] Allow creation of adHoc data Views from no data page [SharedUX] Allow creation of adHoc data views from no data page Nov 4, 2022
@majagrubic majagrubic added v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 4, 2022
@majagrubic majagrubic marked this pull request as ready for review November 4, 2022 19:19
@majagrubic majagrubic requested review from a team November 4, 2022 19:19
@majagrubic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 379.2KB 379.4KB +194.0B
discover 412.9KB 413.1KB +194.0B
kibanaOverview 46.6KB 46.8KB +194.0B
lens 1.3MB 1.3MB +194.0B
visualizations 246.3KB 246.5KB +194.0B
total +970.0B
Unknown metric groups

API count

id before after diff
@kbn/shared-ux-page-analytics-no-data 13 14 +1
@kbn/shared-ux-prompt-no-data-views 24 25 +1
total +2

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@majagrubic majagrubic merged commit 2619f04 into elastic:main Nov 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 7, 2022
@majagrubic majagrubic deleted the nodata-adhoc-dataviews branch November 7, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants