Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Should be able to create ad-hoc data views from no data screen in Discover. #143676

Closed
ymao1 opened this issue Oct 19, 2022 · 6 comments · Fixed by #147850
Closed

[Discover] Should be able to create ad-hoc data views from no data screen in Discover. #143676

ymao1 opened this issue Oct 19, 2022 · 6 comments · Fixed by #147850
Assignees
@dimaanj
Labels
8.7 candidate enhancement New value added to drive a business result Feature:Discover Discover Application Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ymao1
Copy link
Contributor

ymao1 commented Oct 19, 2022 •
edited
Loading

When trying to create an ad-hoc data view from Discover when I don't have an existing saved data view, I see
Screen Shot 2022-10-19 at 11 19 17 AM

When I click Create data view, I see
Screen Shot 2022-10-19 at 11 19 41 AM

which does not surface the ability to create an ad-hoc data view.
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 19, 2022
@majagrubic majagrubic added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Oct 19, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 19, 2022
@ymao1 ymao1 changed the title [Discover] Should be able to create ad-hoc data views with no data. [Discover] Should be able to create ad-hoc data views from no data screen in Discover. Oct 19, 2022
@majagrubic majagrubic mentioned this issue Nov 4, 2022
Merged
3 tasks
@majagrubic
Copy link
Contributor

majagrubic commented Nov 4, 2022 •
edited
Loading

I had a look at this, and my understanding is that ad-hoc data views is a Discover concept. As such, there is no way for data views service to know if it one been created or not. I can update the components to take an additional parameter that would render "Create adHoc data view" button in the DataViewEditor, but Discover will need to handle callback once that is executed and set its state in a way that wouldn't show no data page anymore.

@majagrubic majagrubic added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Nov 7, 2022
@davismcphee davismcphee added Feature:Discover Discover Application enhancement New value added to drive a business result labels Nov 7, 2022
@ninoslavmiskovic
Copy link
Contributor

@kertal @davismcphee this seems like a bug and not by design. Seems like the empty stage was left out as part of the implementation? What do you think ?

@kertal
Copy link
Member

kertal commented Nov 8, 2022

I wouldn't consider it as a bug, if so, it's a UX bug. We're rolling out ad-hoc ones step by step. And supporting this would be another step 👍

@kertal kertal added 8.7 candidate and removed Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Nov 8, 2022
@davismcphee
Copy link
Contributor

I interpreted this similarly to @kertal since I didn't think it was intended to be part of the initial support, but I don't have a strong opinion on it either.

@ninoslavmiskovic ninoslavmiskovic added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Nov 9, 2022
@majagrubic
Copy link
Contributor

Is there a way to make this a part of data views? So that we could call something like dataViews.adHocDataViewExists?

@kertal kertal added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Nov 17, 2022
@petrklapka petrklapka added the Feature:Search Querying infrastructure in Kibana label Nov 21, 2022
@kertal kertal mentioned this issue Nov 22, 2022
Closed
2 tasks
@dimaanj dimaanj mentioned this issue Dec 20, 2022
Merged
dimaanj added a commit that referenced this issue Dec 29, 2022
@dimaanj @kibanamachine
[Discover] Enable adhoc data views creation from no data views state (#…
cbaf020 
…147850)

## Summary

Closes #143676

This PR enables adhoc data views creation from no data views state.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimaanj dimaanj

Labels
8.7 candidate enhancement New value added to drive a business result Feature:Discover Discover Application Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Enable adhoc data views creation from no data views state dimaanj/kibana
8 participants
@kertal @majagrubic @ymao1 @elasticmachine @davismcphee @dimaanj @petrklapka @ninoslavmiskovic