[Actionable Observability] Refactor alert search bar #143840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kdelemme
reviewed
Oct 25, 2022
Comment on lines
-152
to
-170
| const setAlertStatusFilter = useCallback( | ||
| (id: string, query: string) => { | ||
| setAlertFilterStatus(id as AlertStatusFilterButton); | ||
| // Updating the KQL query bar alongside with user inputs is tricky. | ||
| // To avoid issue, this function always remove the AlertFilter and add it | ||
| // at the end of the query, each time the filter is added/updated/removed (Show All) | ||
| // NOTE: This (query appending) will be changed entirely: https://github.com/elastic/kibana/issues/116135 | ||
| let output; | ||
| if (kuery === '') { | ||
| output = query; | ||
| } else { | ||
| const queryWithoutAlertFilter = kuery.replace(ALERT_STATUS_REGEX, ''); | ||
| output = `${queryWithoutAlertFilter} and ${query}`; | ||
| } | ||
| onQueryChange({ | ||
| dateRange: { from: rangeFrom, to: rangeTo }, | ||
| // Clean up the kuery from unwanted trailing/ahead ANDs after appending and removing filters. | ||
| query: output.replace(/^\s*and\s*|\s*and\s*$/gm, ''), | ||
| }); |
kdelemme
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
LGTM, good job @maryam-saeidi!
Tested locally, and works as expected 👍🏻
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142713
Summary
The following changes were applied to the search bar as a prerequisite to sharing this component via the triggers_action_ui plugin:
SearchBarprovided by unified search (as suggested in [RAC] [Observability] Integrate the alerts search bar with the filter, query and time manager #116135)How to test