Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable observability] Refactor alert search bar #143371

Conversation

maryam-saeidi
Copy link
Member

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 14, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Date selection Correctly applies date picker selections
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Date selection Correctly applies date picker selections
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Filtering "after all" hook for "Displays a no data state when filters produce zero results"
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Filtering "after all" hook for "Displays a no data state when filters produce zero results"
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Filtering "after each" hook for "Applies filters correctly"
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Filtering "after each" hook for "Applies filters correctly"
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Filtering Applies filters correctly
  • [job] [logs] FTR Configs #21 / ObservabilityApp Observability alerts Alerts table Filtering Applies filters correctly

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 525 526 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 530.0KB 530.3KB +296.0B
Unknown metric groups

API count

id before after diff
observability 529 530 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maryam-saeidi
Copy link
Member Author

These changes will be applied in another PR: #143840

@maryam-saeidi maryam-saeidi deleted the 142208-fix-alert-table-time-filter branch December 19, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants