[Files] Refactor how types are shared between server and client #141580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: [Files] Use self destruct flag in upload component (elastic#141366) [Synthetics] Unskip certs flaky test (elastic#141423) updated openapi for bulk action responses (elastic#141566) Fix page responsiveness for smaller screen sizes (elastic#141471)
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
kibanamachine
pushed a commit
that referenced
this pull request
Sep 23, 2022
) * migrated uploads component and added new way of typing and creating an endpoint * updated create endpoint types * convert delete endpoint * convert download endpoint * convert get by id endpoint * convert list endpoint * convert update endpoint * convert public facing download * convert share get * convert list shares * missed a spot * remove unused import * convert share endpoint * convert unshare endpoint * convert find find endpoint, fix types and fix use of empty value check * convert metrics (cherry picked from commit 6429468)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2022
) (#141643) * migrated uploads component and added new way of typing and creating an endpoint * updated create endpoint types * convert delete endpoint * convert download endpoint * convert get by id endpoint * convert list endpoint * convert update endpoint * convert public facing download * convert share get * convert list shares * missed a spot * remove unused import * convert share endpoint * convert unshare endpoint * convert find find endpoint, fix types and fix use of empty value check * convert metrics (cherry picked from commit 6429468) Co-authored-by: Jean-Louis Leysens <jeanlouis.leysens@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation declares all types under
commonand shares these withpublicandserver. This results in some duplication because types can be derived from the @kbn/config-schema objects, so we can use them as the source of truth of endpoint input values.Refactor out some repetitive declarations: convert the way we declare the share types to derive their shape from the runtime type checks that live on the server.
The convention is, per endpoint:
CreateEndpointtype as a generic argumentCreateEndpoint, i.e.,Endpoint, to derive types for the client