Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Fix page responsiveness for smaller screen sizes #141471

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

efegurkan
Copy link
Member

Summary

These fixes makes page wrap properly on smaller devices. It will fix word breaks on header and make both cards wrap properly when they don't fit the page.

Previously:

Screen.Recording.2022-09-22.at.18.04.51.mov

Fixed:

Screen.Recording.2022-09-22.at.18.05.05.mov

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@efegurkan efegurkan added bug Fixes for quality problems that affect the customer experience Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:EnterpriseSearch v8.5.0 v8.6.0 labels Sep 22, 2022
@efegurkan efegurkan requested a review from a team September 22, 2022 16:09
@efegurkan efegurkan changed the title Fix page responsiveness for smaller screen sizes [Enterprise Search] Fix page responsiveness for smaller screen sizes Sep 22, 2022
Copy link
Contributor

@brianmcgue brianmcgue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic! 🪄

These fixes makes page wrap properly on smaller devices. It will fix
word breaks on header and make both cards wrap properly when they don't
fit the page.
@efegurkan efegurkan force-pushed the fix-panel-header-small-devices branch from 95cd581 to b6ef783 Compare September 23, 2022 08:03
@efegurkan efegurkan enabled auto-merge (squash) September 23, 2022 08:04
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +35.0B

History

  • 💛 Build #74941 was flaky 95cd581d3c194068c57b9e364f93628dbcefb8db

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efegurkan efegurkan merged commit ddf5307 into elastic:main Sep 23, 2022
kibanamachine pushed a commit that referenced this pull request Sep 23, 2022
These fixes makes page wrap properly on smaller devices. It will fix
word breaks on header and make both cards wrap properly when they don't
fit the page.

(cherry picked from commit ddf5307)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 23, 2022
* main:
  [Files] Use self destruct flag in upload component (elastic#141366)
  [Synthetics] Unskip certs flaky test (elastic#141423)
  updated openapi for bulk action responses (elastic#141566)
  Fix page responsiveness for smaller screen sizes (elastic#141471)
kibanamachine added a commit that referenced this pull request Sep 23, 2022
These fixes makes page wrap properly on smaller devices. It will fix
word breaks on header and make both cards wrap properly when they don't
fit the page.

(cherry picked from commit ddf5307)

Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
@efegurkan efegurkan deleted the fix-panel-header-small-devices branch October 14, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants