[Security Solution][Detections] adds bulk edit rule actions

[vitaliidm]

Summary

• addresses https://github.com/elastic/security-team/issues/2072
• adds new bulk edit actions: add_rule_actions, set_rule_actions
• moved immutability check from rule validateMutatedParams to action validator. Because, rule immutability depends on actions performed on it, not only on immutable property
• adds some test coverage
• using workaround for [RAM] add support of bulk update "muteAll" rule property in rulesClient #139084, by muting/unmuting single rule. This would only happen:
  • if rule was muted before, throttle set to some value
  • rule was unmuted, throttle set to no_actions

Feature recording

Note: callouts on recording are not up to date

Screen.Recording.2022-08-18.at.12.11.12.mov

Screen

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

• This was checked for breaking API changes and was labeled appropriately

Release note

Adding bulk edit of rule actions

[vitaliidm]

@banderror
Have addressed the comments

Also created a few of tickets:

• [Security Solution] Toast shown after bulk editing mentions "data views" for all actions including those not related to editing index patterns #139897
• [Security Solution] refactor rule variables helper in rule actions form #140019
• [RAM] Execute validateMutatedRuleTypeParams in both update and create methods of rulesClient #140031

[banderror]

@vitaliidm Thank you for addressing the comments and creating the follow-up tickets. I have 2 comments left but none of them seem to be blocking.

Before you merge this PR please assist @elastic/security-docs with anything they might need for reviewing the wording used in the new bulk editing form.

[joepeeples]

Cool new feature, thanks for adding docs team for review! Added a few line edits.

Also, overall we might want to reconsider the name "Add rule actions" (in the "Bulk actions" menu, the flyout title, etc.), because a user might also use this UI to edit or remove actions, not just add. Maybe just the name "Rule actions" would cover all those use cases.

[vitaliidm]

Thanks for your help, @joepeeples

Here is the final version:

• without list
• marked menu and button as bold

Also, overall we might want to reconsider the name "Add rule actions" (in the "Bulk actions" menu, the flyout title, etc.), because a user might also use this UI to edit or remove actions, not just add. Maybe just the name "Rule actions" would cover all those use cases.

This name is in line with other bulk edit actions menu:
Tags -> Add tags -> User can overwrite tags by clicking Overwrite checkbox
Index patterns -> Add Index patterns -> User can overwrite patterns by clicking Overwrite checkbox

[joepeeples]

Here is the final version:

• without list
• marked menu and button as bold

@vitaliidm Thanks for the updated screenshot! Actually I think it's OK to use a bulleted list for the tips, and they probably work better that way; I was just saying that it wasn't necessary to introduce the list the way the original heading was doing.

This name is in line with other bulk edit actions menu: Tags -> Add tags -> User can overwrite tags by clicking Overwrite checkbox Index patterns -> Add Index patterns -> User can overwrite patterns by clicking Overwrite checkbox

That makes sense to me, thanks for the extra context.

[vitaliidm]

@joepeeples

I think it's OK to use a bulleted list for the tips, and they probably work better that way

👍 , got the list back

[joepeeples]

LGTM, thank you! 🚀

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 1a0df5a
• Cloud Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
securitySolution	3049	3054	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	6.4MB	6.4MB	+9.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
securitySolution	261.0KB	260.3KB	-752.0B

History

• 💚 Build #69796 succeeded 9c6dc77
• 💚 Build #69776 succeeded 6f530b2
• 💔 Build #69750 failed cc32c07
• 💛 Build #69432 was flaky c459748
• 💔 Build #69416 failed c1bfbac

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm