Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Toast shown after bulk editing mentions "data views" for all actions including those not related to editing index patterns #139897

Closed
vitaliidm opened this issue Sep 1, 2022 · 4 comments · Fixed by #144497
Closed

[Security Solution] Toast shown after bulk editing mentions "data views" for all actions including those not related to editing index patterns #139897

vitaliidm opened this issue Sep 1, 2022 · 4 comments · Fixed by #144497
Assignees
@maximpn
Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@vitaliidm
Copy link
Contributor

vitaliidm commented Sep 1, 2022 •
edited by banderror
Loading

Related to: #139802

Summary

Current behavior

When applying bulk edit action to rules, the success toast message will appear with the following message:

You've successfully updated X rules. If you did not select to apply changes to rules using Kibana data views, those rules were not updated and will continue using data views.

bulk_edit_success_toast

The second part of the message(If you did not select to apply changes to rules using Kibana data views, those rules were not updated and will continue using data views.) is displayed for any bulk edit action: tags, index patterns, actions, timeline.
But, it is relevant only for bulk editing of index patterns

Proposal

Display message You've successfully updated X rules. for all bulk edit actions: tags, timelines, rule actions.

Display message You've successfully updated X rules. If you did not select to apply changes to rules using Kibana data views, those rules were not updated and will continue using data views. for index patterns bulk edit actions only.

It can be done by checking bulk edit request body, before displaying toast
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 1, 2022
@vitaliidm vitaliidm added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team and removed needs-team Issues missing a team label labels Sep 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@vitaliidm vitaliidm added enhancement New value added to drive a business result triage_needed labels Sep 1, 2022
@vitaliidm vitaliidm mentioned this issue Sep 5, 2022
Merged
3 tasks
@banderror banderror changed the title [Security Solution][Detections] improve bulk edit success toast message [Security Solution][Detections] Toast shown after bulk editing mentions "data views" for all actions including those not related to editing index patterns Sep 6, 2022
@banderror banderror added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed triage_needed enhancement New value added to drive a business result labels Sep 6, 2022
This was referenced Sep 6, 2022
Closed
Closed
@maximpn maximpn self-assigned this Oct 3, 2022
@maximpn maximpn mentioned this issue Oct 5, 2022
Closed
@banderror banderror changed the title [Security Solution][Detections] Toast shown after bulk editing mentions "data views" for all actions including those not related to editing index patterns [Security Solution] Toast shown after bulk editing mentions "data views" for all actions including those not related to editing index patterns Oct 21, 2022
This was referenced Oct 27, 2022
Merged
Merged
@maximpn maximpn linked a pull request Nov 3, 2022 that will close this issue
[Security Solution] Fix success bulk edit toast message #144497
Merged
2 tasks
maximpn added a commit that referenced this issue Nov 3, 2022
@maximpn
[Security Solution] Fix success bulk edit toast message (#144497)
190354a 
**Resolves:** #139897

## Summary

Fixes bulk edit success toast's message. Displays `You've successfully updated X rules. If you did not select to apply changes to rules using Kibana data views, those rules were not updated and will continue using data views.` when rule's index patterns were edited and `You've successfully updated X rules.` in the other cases.

*Before:*

https://user-images.githubusercontent.com/3775283/199676233-d3287d97-8e66-4938-bc80-7c643ca0e0ad.mov

*After:*

https://user-images.githubusercontent.com/3775283/199676250-0814ea26-a9bb-4402-a8db-8c2f0e394563.mov


### Checklist


- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@MadameSheema
Copy link
Member

Reopening just to don't miss to validate it.

@MadameSheema MadameSheema reopened this Nov 4, 2022
@ghost
Copy link

ghost commented Nov 24, 2022

Hi @MadameSheema

we have validated this issue on 8.6.0 BC2 and found this issue to be fixed ✔️ .

Now correct banner message are seen for different bulk operation on rules, tabular observation for each bulk operatation is shared below :-

Observations:

Bulk edit action Sub -Acton Success Banner message on 8.6.0 BC2
Tags Add Tags You've successfully updated X rules.
  Delete Tags You've successfully updated X rules.
Index patterns Add index You've successfully updated X rules. If you did not select to apply changes to rules using Kibana data views, those rules were not updated and will continue using data views.
  Delete Index You've successfully updated X rules. If you did not select to apply changes to rules using Kibana data views, those rules were not updated and will continue using data views.
Rule Actions − You've successfully updated X rules.
Apply Timeline Template − You've successfully updated X rules.

Build Details:

Version: 8.6.0 BC2
Commit:b52b34c2ff5216c395bd49c5fbc97744b646f34d
Build:58485

Screen-Cast

Rules.-.Kibana.Mozilla.Firefox.2022-11-24.07-11-19.mp4

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this as completed Nov 24, 2022
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 24, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Fix success bulk edit toast message maximpn/kibana
5 participants
@maximpn @banderror @elasticmachine @MadameSheema @vitaliidm